refactor: drop the dead listener, use DI and correlate with the server request ID - #5
Merged
Merged
Conversation
ernolf
commented
Jul 17, 2026
ernolf
commented
Owner
- remove HandlerStackReadyListener and the commented-out registration; the core event it waited for still does not exist (roadmap note follows in the README)
- resolve services through IBootContext::getServerContainer() instead of \OC::$server
- replace the dead nc_request_id option with a composite request ID: IRequest::getId() plus a random suffix, correlatable with nextcloud.log and still unique per outgoing request
…r request ID - remove HandlerStackReadyListener and the commented-out registration; the core event it waited for still does not exist (roadmap note follows in the README) - resolve services through IBootContext::getServerContainer() instead of \OC::$server - replace the dead nc_request_id option with a composite request ID: IRequest::getId() plus a random suffix, correlatable with nextcloud.log and still unique per outgoing request Signed-off-by: ernolf <raphael.gradenwitz@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.