chore(renovate): group system-interface with cap-std - #327
Merged
Merged
Conversation
eryx-vfs gets `read_at`/`write_at` on cap-std files from `system_interface::fs::FileIoExt`, via system-interface's `cap_std_impls` feature. Those impls target a specific cap-std major, so a cap-std bump without a matching system-interface does not compile — see #316, where cap-std 4 landed on its own and every positional read/write in eryx-vfs lost its trait impl. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eryx-vfsgetsread_at/write_aton cap-std files fromsystem_interface::fs::FileIoExt, enabled by system-interface'scap_std_implsfeature. Those impls are written against a specific cap-std major, so a cap-std bump on its own does not compile:That is exactly what #316 is — cap-std 4 opened alone and unbuildable. Grouping the two means Renovate only proposes a combination that can actually resolve.
Worth knowing: this also means the group is gated on system-interface's release cadence. Its latest (0.27.3) still requires
cap-std ^3, so there is no combination that takes cap-std 4 today and the group will simply hold until upstream releases support. That is the intended behaviour — better a held group than an unbuildable PR.🤖 Generated with Claude Code