Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update module cards layout, including descriptions #61

Merged
merged 5 commits into from
Jul 30, 2024

Conversation

JaroCamphuijsen
Copy link
Collaborator

@JaroCamphuijsen JaroCamphuijsen commented Jun 11, 2024

  • enable descriptions on the module cards
  • Fix size / shape of modules cards
  • Crop thumbnail portion a bit
  • Have a good back-up default description

Sorry, something went wrong.

@JaroCamphuijsen
Copy link
Collaborator Author

Example screenshot of how this will look:

image

@@ -28,7 +29,7 @@
const modQuery: QueryBuilderParams = {
path: '/modules',
where: [{ visibility: 'visible' }],
sort: [{ id:1, $numeric:true }]
sort: [{ order:1, $numeric:true }]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @JaroCamphuijsen. The changes look pretty nice and the final layout amazing! I tested it locally. One change I cannot really grasp is the id. Will id be replaced by order also in index.md ?

I will approve for now...

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your review @Cmurilochem . Indeed, I replaced the id variable with order because it is more descriptive of how it is used.

@JaroCamphuijsen JaroCamphuijsen merged commit 5cbbe4f into main Jul 30, 2024
1 check passed
@JaroCamphuijsen JaroCamphuijsen deleted the module-cards-layout branch July 30, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants