110 crop raster ep

[rogerkuou]

fix #110

[github-actions]

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

• 🎯 correct output
• 🖼️ correct figures
• ❓ new warnings
• ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/esciencecenter-digital-skills/geospatial-python/compare/md-outputs..md-outputs-PR-112

The following changes were observed in the rendered markdown documents:

 01-intro-raster-data.md                       |  62 ++--
 02-intro-vector-data.md                       |  30 +-
 03-crs.md                                     |  20 +-
 04-geo-landscape.md                           |  24 +-
 07-vector-data-in-python.md                   | 482 ++++++++++++--------------
 08-crop-raster-data.md                        | 268 +++++---------
 fig/E07/greece_administration_areas.png (new) | Bin 0 -> 64055 bytes
 fig/E07/greece_highways.png (new)             | Bin 0 -> 26479 bytes
 fig/E07/rhodes_administration_areas.png (new) | Bin 0 -> 17351 bytes
 fig/E07/rhodes_assets.png (new)               | Bin 0 -> 45400 bytes
 fig/E07/rhodes_builtup_buffer.png (new)       | Bin 0 -> 18396 bytes
 fig/E07/rhodes_highways.png (new)             | Bin 0 -> 80495 bytes
 fig/E07/rhodes_infra_highways.png (new)       | Bin 0 -> 46913 bytes
 fig/E08/dem.png (new)                         | Bin 0 -> 98203 bytes
 fig/E08/dem_matched.png (new)                 | Bin 0 -> 122237 bytes
 fig/E08/visual_clip.png (new)                 | Bin 0 -> 77146 bytes
 fig/E08/visual_clip_box.png (new)             | Bin 0 -> 374262 bytes
 fig/E08/visual_large.png (new)                | Bin 0 -> 197716 bytes
 index.md                                      |  30 +-
 md5sum.txt                                    |  16 +-
 setup.md                                      |  26 +-
 21 files changed, 422 insertions(+), 536 deletions(-)

What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-08 09:47:49 +0000

[rogerkuou]

Hi @Morrizzzzz, I updated EP8, cropping raster data. Can you review it? Thx!

[Morrizzzzz]

Some minor issues, for which I made some suggestions. Have a specific look at episodes/08-crop-raster-data.md line 31 and 32. Good job!

[Morrizzzzz]

check that the search.json is replaced in the figshare file and on line 31 and 32

[rogerkuou]

Thanks @Morrizzzzz, I just updated the data loading part to load from the downloaded files

[Morrizzzzz]

I think that we should explain that we are using the * here to unpack the four coordinates. A little more explanation is required here. I am not sure if everybody gets this straigh away.

[rogerkuou]

@Morrizzzzz I agree. I added some descriptions in the text before this code block, see the changes above. Do you think it's good?

[rogerkuou]

Updated review comments

[rogerkuou]

@Morrizzzzz I agree. I added some descriptions in the text before this code block, see the changes above. Do you think it's good?