Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate SM session metrics to mongoose_instrument #4313

Draft
wants to merge 5 commits into
base: feature/instrument
Choose a base branch
from

Conversation

jacekwegr
Copy link
Contributor

WiP

@mongoose-im

This comment was marked as outdated.

Copy link

codecov bot commented Jun 27, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.01%. Comparing base (7f14efe) to head (c9d896b).

Files Patch % Lines
src/ejabberd_sm.erl 93.33% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/instrument    #4313      +/-   ##
======================================================
- Coverage               84.64%   82.01%   -2.63%     
======================================================
  Files                     556      556              
  Lines                   33881    33896      +15     
======================================================
- Hits                    28678    27801     -877     
- Misses                   5203     6095     +892     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mongoose-im

This comment was marked as outdated.

@mongoose-im

This comment was marked as outdated.

@mongoose-im
Copy link
Collaborator

mongoose-im commented Jun 28, 2024

elasticsearch_and_cassandra_26 / elasticsearch_and_cassandra_mnesia / c9d896b
Reports root/ big
OK: 456 / Failed: 1 / User-skipped: 41 / Auto-skipped: 0

mam_SUITE:elasticsearch_muc_all:muc_prefs_cases:muc_prefs_set_cdata_request
{error,
  {function_clause,
    [{mam_helper,parse_children_prefs_iq,
       [{xmlel,<<"error">>,
          [{<<"code">>,<<"501">>},{<<"type">>,<<"cancel">>}],
          [{xmlel,<<"feature-not-implemented">>,
             [{<<"xmlns">>,
             <<"urn:ietf:params:xml:ns:xmpp-stanzas">>}],
             []},
           {xmlel,<<"text">>,
             [{<<"xmlns">>,
             <<"urn:ietf:params:xml:ns:xmpp-stanzas">>}],
             [{xmlcdata,<<"From mod_mam_muc">>}]}]},
        {prefs_result_iq,undefined,[],[]}],
       []},
     {lists,foldl,3,[{file,"lists.erl"},{line,1594}]},
     {mam_SUITE,'-muc_prefs_set_cdata_request/1-fun-0-',2,
       [{file,"/home/circleci/project/big_tests/tests/mam_SUITE.erl"},
        {line,3457}]},
     {escalus_story,story,4,
       [{file,
          "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
        {line,72}]},
     {muc_helper,story_with_room,4,
       [{file,"/home/circleci/project/big_tests/tests/muc_helper.erl"},
        {line,318}]},
     {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
     {test_server,run_test_case_eval1,6,
       [{file,"test_server.erl"},{line,1302}]},
     {test_server,run_test_case_eval,9,
       [{file,"test_server.erl"},{line,1234}]}]}}

Report log


small_tests_25 / small_tests / c9d896b
Reports root / small


small_tests_26 / small_tests / c9d896b
Reports root / small


small_tests_26_arm64 / small_tests / c9d896b
Reports root / small


ldap_mnesia_25 / ldap_mnesia / c9d896b
Reports root/ big
OK: 2286 / Failed: 0 / User-skipped: 906 / Auto-skipped: 0


ldap_mnesia_26 / ldap_mnesia / c9d896b
Reports root/ big
OK: 2286 / Failed: 0 / User-skipped: 906 / Auto-skipped: 0


dynamic_domains_mysql_redis_26 / mysql_redis / c9d896b
Reports root/ big
OK: 4583 / Failed: 1 / User-skipped: 139 / Auto-skipped: 0

carboncopy_SUITE:one2one:dropped_client_doesnt_create_duplicate_carbons
{error,
  {{badmatch,
     [{xmlel,<<"message">>,
        [{<<"from">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_595@domain.example.com">>},
         {<<"to">>,
        <<"alice_dropped_client_doesnt_create_duplicate_carbons_595@domain.example.com/res2">>},
         {<<"xmlns">>,<<"jabber:client">>},
         {<<"type">>,<<"chat">>}],
        [{xmlel,<<"sent">>,
           [{<<"xmlns">>,<<"urn:xmpp:carbons:2">>}],
           [{xmlel,<<"forwarded">>,
            [{<<"xmlns">>,<<"urn:xmpp:forward:0">>}],
            [{xmlel,<<"message">>,
               [{<<"from">>,
                 <<"alice_dropped_client_doesnt_create_duplicate_carbons_595@domain.example.com/res1">>},
                {<<"type">>,<<"chat">>},
                {<<"to">>,
                 <<"bob_dropped_client_doesnt_create_duplicate_carbons_595@domain.example.com/res1">>},
                {<<"xmlns">>,<<"jabber:client">>}],
               [{xmlel,<<"body">>,[],
                  [{xmlcdata,
                     <<"And pious action">>}]}]}]}]}]}]},
   [{carboncopy_SUITE,
      '-dropped_client_doesnt_create_duplicate_carbons/1-fun-0-',4,
      [{file,
         "/home/circleci/project/big_tests/tests/carboncopy_SUITE.erl"},
       {line,189}]},
    {escalus_story,story,4,
      [{file,
         "/home/circleci/project/big_tests/_build/default/lib/escalus/src/escalus_story.erl"},
       {line,72}]},
    {test_server,ts_tc,3,[{file,"test_server.erl"},{line,1793}]},
    {test_server,run_test_c...

Report log


dynamic_domains_pgsql_mnesia_25 / pgsql_mnesia / c9d896b
Reports root/ big
OK: 4617 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0


dynamic_domains_pgsql_mnesia_26 / pgsql_mnesia / c9d896b
Reports root/ big
OK: 4617 / Failed: 0 / User-skipped: 106 / Auto-skipped: 0


internal_mnesia_26 / internal_mnesia / c9d896b
Reports root/ big
OK: 2426 / Failed: 0 / User-skipped: 766 / Auto-skipped: 0


pgsql_cets_26 / pgsql_cets / c9d896b
Reports root/ big
OK: 4516 / Failed: 0 / User-skipped: 174 / Auto-skipped: 0


pgsql_mnesia_25 / pgsql_mnesia / c9d896b
Reports root/ big
OK: 5009 / Failed: 0 / User-skipped: 113 / Auto-skipped: 0


dynamic_domains_mssql_mnesia_26 / odbc_mssql_mnesia / c9d896b
Reports root/ big
OK: 4614 / Failed: 0 / User-skipped: 109 / Auto-skipped: 0


mysql_redis_26 / mysql_redis / c9d896b
Reports root/ big
OK: 4988 / Failed: 0 / User-skipped: 134 / Auto-skipped: 0


mssql_mnesia_26 / odbc_mssql_mnesia / c9d896b
Reports root/ big
OK: 5006 / Failed: 0 / User-skipped: 116 / Auto-skipped: 0


pgsql_mnesia_26 / pgsql_mnesia / c9d896b
Reports root/ big
OK: 5009 / Failed: 0 / User-skipped: 113 / Auto-skipped: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants