fix: crash on for statement in *-prototype-* rules (#224)

eslint-community · Nov 18, 2024 · 3c0af8a · 3c0af8a
1 parent 561e75b
commit 3c0af8a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 0 deletions.
diff --git a/lib/util/define-nonstandard-prototype-properties-handler/index.js b/lib/util/define-nonstandard-prototype-properties-handler/index.js
@@ -93,6 +93,9 @@ function defineNonstandardPrototypePropertiesHandler(
                 assignmentNode.type === "VariableDeclarator"
                     ? assignmentNode.init
                     : assignmentNode.right
+            if (!objectNode) {
+                return
+            }
 
             for (const className of classNames) {
                 if (!objectTypeChecker(node, objectNode, className)) {

diff --git a/lib/util/define-prototype-method-handler/index.js b/lib/util/define-prototype-method-handler/index.js
@@ -104,6 +104,9 @@ function definePrototypeMethodHandler(context, nameMap, options) {
                     assignmentNode.type === "VariableDeclarator"
                         ? assignmentNode.init
                         : assignmentNode.right
+                if (!objectNode) {
+                    return
+                }
                 let objectTypeResult = undefined
                 if (
                     methodNames.includes(propertyName) &&
@@ -163,6 +166,9 @@ function definePrototypeMethodHandler(context, nameMap, options) {
                 assignmentNode.type === "VariableDeclarator"
                     ? assignmentNode.init
                     : assignmentNode.right
+            if (!objectNode) {
+                return
+            }
             for (const [className, methodNames] of nameMapEntries) {
                 let objectTypeResult = undefined
                 if (

diff --git a/tests/lib/rules/no-array-prototype-at.js b/tests/lib/rules/no-array-prototype-at.js
@@ -21,6 +21,8 @@ new RuleTester().run(ruleId, rule, {
             options: [{ aggressive: false }],
             settings: { "es-x": { aggressive: true } },
         },
+        // Test for https://github.com/eslint-community/eslint-plugin-es-x/issues/223
+        "for (const { x } of foo) {}",
     ],
     invalid: [
         {

diff --git a/tests/lib/rules/no-nonstandard-array-prototype-properties.js b/tests/lib/rules/no-nonstandard-array-prototype-properties.js
@@ -17,6 +17,8 @@ new RuleTester().run(ruleId, rule, {
         "['A'][0]",
         "['A']['0']",
         { code: "['A'].unknown()", options: [{ allow: ["unknown"] }] },
+        // Test for https://github.com/eslint-community/eslint-plugin-es-x/issues/223
+        "for (const { x } of foo) {}",
     ],
     invalid: [
         {