Skip to content

Commit

Permalink
feat: drop Node 6, 8 & 10 support (#16)
Browse files Browse the repository at this point in the history
BREAKING CHANGE: Requires Node@^12.22.0 || ^14.17.0 || >=16.0.0
  • Loading branch information
MichaelDeBoey committed Jul 29, 2023
1 parent a5ee7f1 commit 1d1284e
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 109 deletions.
33 changes: 3 additions & 30 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ jobs:
strategy:
matrix:
eslint: [7]
node: [10, 12.0.0, 12, 14.0.0, 14, 16.0.0, 16, 18.0.0, 18, 20]
node: [12.22.0, 12, 14.17.0, 14, 16.0.0, 16, 18.0.0, 18, 20]
os: [ubuntu-latest]
include:
# On other platforms
Expand All @@ -63,16 +63,9 @@ jobs:
- eslint: 4
node: 18
os: ubuntu-latest
# On old Node.js versions
- eslint: 6
node: 8
os: ubuntu-latest
- eslint: 5
node: 6
os: ubuntu-latest
# On the minimum supported ESLint/Node.js version
- eslint: 4.19.1
node: 6.5.0
node: 12.22.0
os: ubuntu-latest
runs-on: ${{ matrix.os }}
steps:
Expand All @@ -84,31 +77,11 @@ jobs:
with:
node-version: ${{ matrix.node }}

# - name: 📥 Install dependencies
# run: npm install
- name: 📥 Install Packages for Node v6
run: |
sudo npm i [email protected]
./node_modules/.bin/npm -v
./node_modules/.bin/npm uninstall vuepress
./node_modules/.bin/npm install
if: ${{ matrix.node == '6.5.0' || matrix.node == '6' }}
- name: 📥 Uninstall Packages for Node v8
run: |
npm uninstall vuepress
if: ${{ matrix.node == '8.O.O' || matrix.node == '8' }}
- name: 📥 Install Packages
- name: 📥 Install dependencies
run: npm install --legacy-peer-deps
if: ${{ matrix.node != '6.5.0' && matrix.node != '6' }}

# - name: 📥 Install ESLint v${{ matrix.eslint }}
# run: npm install --save-dev eslint@${{ matrix.eslint }}
- name: 📥 Install ESLint v${{ matrix.eslint }} for Node v6
run: ./node_modules/.bin/npm install --save-dev eslint@${{ matrix.eslint }}
if: ${{ matrix.node == '6.5.0' || matrix.node == '6' }}
- name: 📥 Install ESLint v${{ matrix.eslint }}
run: npm install --save-dev eslint@${{ matrix.eslint }}
if: ${{ matrix.node != '6.5.0' && matrix.node != '6' }}

- name: ▶️ Run test script
run: npm run test
Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ npm install --save-dev eslint @eslint-community/eslint-plugin-eslint-comments
```

::: tip Requirements
- Node.js `6.5.0` or newer.
- Node.js `^12.22.0 || ^14.17.0 || >=16.0.0`
- ESLint `4.19.1` or newer.
:::

Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.0.0-semantically-released",
"description": "Additional ESLint rules for ESLint directive comments.",
"engines": {
"node": ">=6.5.0"
"node": "^12.22.0 || ^14.17.0 || >=16.0.0"
},
"main": "index.js",
"files": [
Expand Down Expand Up @@ -41,7 +41,6 @@
"clean": "rimraf .nyc_output coverage docs/.vuepress/dist",
"docs:build": "vuepress build docs",
"docs:watch": "vuepress dev docs",
"docs:deploy": "node scripts/deploy",
"lint": "eslint lib scripts tests",
"test": "nyc mocha \"tests/lib/**/*.js\" --reporter dot --timeout 8000",
"coverage": "nyc report --reporter lcov && opener coverage/lcov-report/index.html",
Expand Down
76 changes: 0 additions & 76 deletions scripts/deploy.js

This file was deleted.

0 comments on commit 1d1284e

Please sign in to comment.