Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: explicitly support ESLint 9.0.0 pre-releases #200

Merged
merged 1 commit into from
Mar 10, 2024
Merged

fix: explicitly support ESLint 9.0.0 pre-releases #200

merged 1 commit into from
Mar 10, 2024

Conversation

voxpelli
Copy link
Member

Fixes #197 using the solution from eslint-community/eslint-utils#206

Only time that ^8.23.0 || >=9.0.0-0 may cause an issue is if we ship a stable version of 17.0.0 before ESLint ships a stable version of 9.0.0.

We may want to keep >=8.23.0 in our stable releases and only set it to ^8.23.0 || >=9.0.0-0 in our pre-releases.

@voxpelli voxpelli requested a review from a team March 10, 2024 14:15
@voxpelli voxpelli self-assigned this Mar 10, 2024
scagood
scagood approved these changes Mar 10, 2024
View reviewed changes
Copy link

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@voxpelli voxpelli merged commit a5eaa9c into master Mar 10, 2024
17 checks passed
@voxpelli voxpelli deleted the voxpelli/issue197 branch March 10, 2024 20:14
@github-actions github-actions bot mentioned this pull request Mar 10, 2024
Merged
aladdin-add added a commit that referenced this pull request Apr 7, 2024
@aladdin-add
Revert "fix: explicitly support ESLint 9.0.0 pre-releases (#200)"
c2ccff8 
This reverts commit a5eaa9c.
aladdin-add added a commit that referenced this pull request Apr 7, 2024
@aladdin-add
fix: change peer dependencies to allow eslint v9 (#216)
5e82d7f 
* Revert "fix: explicitly support ESLint 9.0.0 pre-releases (#200)"

This reverts commit a5eaa9c.

* build: tests on eslint v9

* chore: fix linting errors

* chore: fix eslint v9 tests
@wakamsha wakamsha mentioned this pull request May 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scagood scagood scagood approved these changes

Assignees

@voxpelli voxpelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support ESLint >=9.0.0-beta.1 in peer dependency
2 participants
@voxpelli @scagood