feat(resolve): allow overriding enhanced-resolve's options #384
+149
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GertSallaerts
changed the title
scagood
added
enhancement
typescript
accepted
rule:update
|
Thank you for you PR! I will review it first thing tomorrow morning. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
GertSallaerts
changed the title
aladdin-add
reviewed
Nov 21, 2024
|
|
||
| Override the options generated by this plugin for resolving require and import statements. These | ||
| options are passed down to `enhanced-resolve`'s factory method and are documented [here on their | ||
| GitHub repository](https://github.com/webpack/enhanced-resolve?tab=readme-ov-file#resolver-options). |
There was a problem hiding this comment.
I'm a bit concerned that this will over-bind this package to enhanced-resolve, which may make it harder for us to make changes in the future - e.g. moving to import.meta.resolve (which I remember it has been discussed somewhere before).
We can state the minimum necessary in the docs. wdty?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows you to customize the config for module resolution. See: https://github.com/webpack/enhanced-resolve?tab=readme-ov-file#resolver-options
Old description (the PR was initially intended to only specify the
modulesoption)Allows you to do things like:
srcfolder as amodulesfolder andrequire('models/foo');from within yoursrcfolderBasically this: https://webpack.js.org/configuration/resolve/#resolvemodules
That second bullet point used to be possible by just setting
resolvePathsbut going from this comment on #139 that was considered an unintended side-effect or bug.