prefer-await-to-then should flag promise.catch/finally as well

[jp7837]

What is the purpose of this pull request?

• Documentation update
• Bug fix
• New rule
• Changes an existing rule
• Add autofixing to a rule
• Other, please explain:

What changes did you make? (Give an overview)
Flag catch() and finally() usages in the prefer-await-to-then rule

[jp7837]

Fixes #187

[jp7837]

@xjamundx thoughts on this one?

[xjamundx]

Yeah seems fine.

[xjamundx]

Actually.....Let me take this back (sorry).

.catch() really is an error handling mechanism and not really the same as await.

For example I prefer .catch() to try/catch as in let val = await whatever().catch() vs

let val;
try {
   val = await whatever();
} catch (e) {
   val = default;
}

So, sorry I am not going to include this.

[jp7837]

@xjamundx yeah, that makes sense, it is cleaner to use catch() in that case. I just used the below instead. And I was actually just applying it to Jest code in combination with no-try-expect to get more reliable and cleaner error assertions.

"no-restricted-properties": [
	"error",
	{
		property: "catch",
		message: "Use async/await instead of catch"
	},
	{
		property: "finally",
		message: "Use async/await instead of finally"
	},
	{
		property: "then",
		message: "Use async/await instead of then"
	},
]