Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(catch-or-return): add allowThenStrict option #522

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

brettz9
Copy link
Member

@brettz9 brettz9 commented Jul 30, 2024

What is the purpose of this pull request?

  • Changes an existing rule

What changes did you make? (Give an overview)

Added an allowThenStrict option which will fail on then(fn1, fn2) but pass on then(null, fn)

Also cleaned up the allowThen docs and tests.

Closes #52

Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bbcfcbf) to head (1a0161f).
Report is 61 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #522   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        26    +1     
  Lines          649       699   +50     
  Branches       250       268   +18     
=========================================
+ Hits           649       699   +50     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MichaelDeBoey MichaelDeBoey changed the title feat: add allowThenStrict option feat(catch-or-return): add allowThenStrict option Oct 9, 2024
Copy link
Contributor

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@brettz9 brettz9 merged commit 53be970 into eslint-community:main Oct 16, 2024
11 checks passed
@brettz9 brettz9 deleted the allowThenStrict branch October 16, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

catch-or-return options to report then(a, b) or then(null, b)
3 participants