-
-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): switch from dependabot to renovate using shared eslint community configuration #537
chore(deps): switch from dependabot to renovate using shared eslint community configuration #537
Conversation
Signed-off-by: Jérôme Benoit <[email protected]>
Or do like This would be preferable I think, and we could eventually do a superset / alternative renovate config for |
The intent was to reduce the deps maintenance overhead with a minimum work and the current tooling: instead of having X PRs to review/merge, you now have 2 PRs maximum with the minimum sensible update semantic. Changing the deps maintenance tooling for better one was not the scope. |
Sure, but I would rather align across this and eg. eslint-plugin-n rather than have each do their own thing. Any downside to that? |
The amount of work is not the same, at all. And the two are not mutually exclusive:
|
Adding the same renovate config as {
"$schema": "https://docs.renovatebot.com/renovate-schema.json",
"extends": ["github>eslint/eslint//.github/renovate.json5"]
} It would take me mere minutes to do, but want opinions from eg. @brettz9 and @scagood before doing so |
Im in favour of copying the other community repos too 👍 |
Haven't used Renovate personally, but no strong opinions about it either way. (In my personal projects I like to just use |
Signed-off-by: Jérôme Benoit <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favour of this, thank you 💪
Merged, thanks @jerome-benoit 🙏 The original issue of the grouping is something we can revisit when we see how this works out 👍 |
What is the purpose of this pull request?
Reduce dependencies management overhead.
What changes did you make? (Give an overview)
The post configuration on the repo needs an admin: https://github.com/renovatebot/renovate/blob/main/docs/usage/getting-started/installing-onboarding.md