Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): switch from dependabot to renovate using shared eslint community configuration #537

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

jerome-benoit
Copy link
Contributor

@jerome-benoit jerome-benoit commented Aug 8, 2024

What is the purpose of this pull request?

  • Documentation update
  • Bug fix
  • New rule
  • Changes an existing rule
  • Add autofixing to a rule
  • Other, please explain:

Reduce dependencies management overhead.

What changes did you make? (Give an overview)

The post configuration on the repo needs an admin: https://github.com/renovatebot/renovate/blob/main/docs/usage/getting-started/installing-onboarding.md

@voxpelli
Copy link
Member

Or do like eslint-plugin-n and move to Renovate: eslint-community/eslint-plugin-n#44 (see dependency dashboard at eslint-community/eslint-plugin-n#150)

This would be preferable I think, and we could eventually do a superset / alternative renovate config for eslint-community rather than just using the ESLint one directly, and that could be shared between eg. plugin-n and plugin-promise

@jerome-benoit
Copy link
Contributor Author

The intent was to reduce the deps maintenance overhead with a minimum work and the current tooling: instead of having X PRs to review/merge, you now have 2 PRs maximum with the minimum sensible update semantic.

Changing the deps maintenance tooling for better one was not the scope.

@voxpelli
Copy link
Member

Sure, but I would rather align across this and eg. eslint-plugin-n rather than have each do their own thing. Any downside to that?

@jerome-benoit
Copy link
Contributor Author

The amount of work is not the same, at all.

And the two are not mutually exclusive:

  • 5 min work and a few lines of code to improve the current situation
  • An issue to switch to renovate later with the creation of whatever shared configuration for eslint plugins: hours of work

@voxpelli
Copy link
Member

Adding the same renovate config as eslint-plugin-n requires simply removing the dependabot config and adding a .github/renovate.json file with:

{
    "$schema": "https://docs.renovatebot.com/renovate-schema.json",
    "extends": ["github>eslint/eslint//.github/renovate.json5"]
}

It would take me mere minutes to do, but want opinions from eg. @brettz9 and @scagood before doing so

@scagood
Copy link
Contributor

scagood commented Aug 15, 2024

Adding the same renovate config as eslint-plugin-n requires simply removing the dependabot config and adding a .github/renovate.json file with:

{
    "$schema": "https://docs.renovatebot.com/renovate-schema.json",
    "extends": ["github>eslint/eslint//.github/renovate.json5"]
}

It would take me mere minutes to do, but want opinions from eg. @brettz9 and @scagood before doing so

Im in favour of copying the other community repos too 👍

@brettz9
Copy link
Member

brettz9 commented Aug 15, 2024

Haven't used Renovate personally, but no strong opinions about it either way.

(In my personal projects I like to just use npm-check-updates to periodically update dependencies locally, without any remote noise at all. :-) )

Signed-off-by: Jérôme Benoit <[email protected]>
@jerome-benoit jerome-benoit changed the title chore(deps): group dependabot updates per type chore(deps): switch from dependabot to renovate Aug 19, 2024
@jerome-benoit jerome-benoit changed the title chore(deps): switch from dependabot to renovate chore(deps): switch from dependabot to renovate using shared eslint community configuration Aug 19, 2024
Copy link
Contributor

@scagood scagood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favour of this, thank you 💪

@voxpelli voxpelli merged commit 30efed7 into eslint-community:main Aug 21, 2024
2 checks passed
@voxpelli
Copy link
Member

Merged, thanks @jerome-benoit 🙏

The original issue of the grouping is something we can revisit when we see how this works out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants