fix: Ensure everything works with ESLint v9 #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aladdin-add
approved these changes
Apr 9, 2024
rules/detect-child-process.js
Outdated
| @@ -46,14 +47,14 @@ module.exports = { | |||
| !node.arguments.length || | |||
| isStaticExpression({ | |||
| node: node.arguments[0], | |||
| scope: context.getScope(), | |||
| scope: sourceCode.getScope(node.arguments[0]), | |||
There was a problem hiding this comment.
Shouldn't it be like
scope: sourceCode.getScpe ? sourceCode.getScope(node) : context.getScope();
for a better backward compatibility?
Otherwise, this plugin will require the ESLint v8.37.0 or newer, which makes it not backward compatible and should lead to a major version bump.
There was a problem hiding this comment.
That's a good point. We may end up doing a breaking release anyway for #146 but I can make this change.
amaximov-apollon
approved these changes
Apr 10, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated APIs and dependencies to work with ESLint v9.
fixes #144