fix: d should be invalid in ES2021 (#209)

eslint-community · Oct 28, 2024 · c4852c9 · c4852c9
1 parent 347b151
commit c4852c9
Show file tree

Hide file tree

Showing 6 changed files with 63 additions and 1 deletion.
diff --git a/src/validator.ts b/src/validator.ts
@@ -3569,7 +3569,7 @@ export class RegExpValidator {
             validFlags.add(LATIN_SMALL_LETTER_Y)
             if (this.ecmaVersion >= 2018) {
                 validFlags.add(LATIN_SMALL_LETTER_S)
-                if (this.ecmaVersion >= 2021) {
+                if (this.ecmaVersion >= 2022) {
                     validFlags.add(LATIN_SMALL_LETTER_D)
                     if (this.ecmaVersion >= 2024) {
                         validFlags.add(LATIN_SMALL_LETTER_V)

diff --git a/test/fixtures/parser/literal/flags-2021.json → test/fixtures/parser/literal/flags-2022.json b/test/fixtures/parser/literal/flags-2021.json → test/fixtures/parser/literal/flags-2022.json
diff --git a/test/fixtures/parser/literal/flags-invalid-2017.json b/test/fixtures/parser/literal/flags-invalid-2017.json
@@ -0,0 +1,14 @@
+{
+  "options": {
+    "strict": true,
+    "ecmaVersion": 2017
+  },
+  "patterns": {
+    "/./s": {
+      "error": {
+        "message": "Invalid regular expression: /./s: Invalid flag 's'",
+        "index": 3
+      }
+    }
+  }
+}
diff --git a/test/fixtures/parser/literal/flags-invalid-2021.json b/test/fixtures/parser/literal/flags-invalid-2021.json
@@ -0,0 +1,14 @@
+{
+  "options": {
+    "strict": true,
+    "ecmaVersion": 2021
+  },
+  "patterns": {
+    "/./d": {
+      "error": {
+        "message": "Invalid regular expression: /./d: Invalid flag 'd'",
+        "index": 3
+      }
+    }
+  }
+}
diff --git a/test/fixtures/parser/literal/flags-invalid-2023.json b/test/fixtures/parser/literal/flags-invalid-2023.json
@@ -0,0 +1,14 @@
+{
+  "options": {
+    "strict": true,
+    "ecmaVersion": 2023
+  },
+  "patterns": {
+    "/./v": {
+      "error": {
+        "message": "Invalid regular expression: /./v: Invalid flag 'v'",
+        "index": 3
+      }
+    }
+  }
+}
diff --git a/test/fixtures/parser/literal/flags-invalid-5.json b/test/fixtures/parser/literal/flags-invalid-5.json
@@ -0,0 +1,20 @@
+{
+  "options": {
+    "strict": true,
+    "ecmaVersion": 5
+  },
+  "patterns": {
+    "/./u": {
+      "error": {
+        "message": "Invalid regular expression: /./u: Invalid flag 'u'",
+        "index": 3
+      }
+    },
+    "/./y": {
+      "error": {
+        "message": "Invalid regular expression: /./y: Invalid flag 'y'",
+        "index": 3
+      }
+    }
+  }
+}