Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create eslint-community GitHub organization #91
feat: create eslint-community GitHub organization #91
Changes from all commits
2765132
cc49e34
f8ce202
535afc6
bec2d70
5046d59
35bc00d
7b6fa59
89a5524
ed9c14c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like there's ambiguity around when we should move an NPM package to the
@eslint-community
NPM scope.On the one hand, it would be nice to keep the existing NPM package name whenever possible to avoid churn so the thousands or millions of users of the package don't have to manually switch from the old name to the new name (the majority of users might never even get around to doing this, resulting in substantial fragmentation). This is my preference.
On the other, there might be organizational benefits to moving packages to scopes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there's much benefit to moving an npm package name. I agree whenever possible we'd want to avoid churn, so the only use case there would be when the original name was somehow unrecoverable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was about to write the same as @ljharb 👍 Only move when it needs to move
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should aim to get the original repo/npm package, if that's not possible, we should go with a fork and/or publish it under the org namespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you really and to do this, then we need more details on how it would work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice if you could help me understand what @eslintbot is doing on the main repo & how it's set up there in order to write down how we could use it in the community org.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think we’d want the same setup. @eslintbot is a GitHub account, and this would only need npm.
My suggestion: packages can tag and create GitHub releases, and that would trigger an action/workflow (unsure of specifics) that would use the npm eslintbot account to publish the release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you better define this separation? What tasks would the CCT handle? When would maintainers have to interact with the CCT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maintainers could work on their own without interference of the community core team if they don't want to.
The community core team would in general not interfere with handing day to day business of a specific package if that package has dedicated maintainers.
The community core team would create PRs & a review from the dedicated maintainers would be necessary (just like with all PRs from external people).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let’s be specific: is this a bonus or a must-have? Are we talking one channel? Is it private? What about a space for maintainers to collaborate? Does each package need a channel? Or can they request one?
Should this be a separate Discord server?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me personally, this is not a must-have, as we could operate the new org without it, but it's more like a "really nice to have".
I think it would be nice to keep this in the same Discord server, but under a separate group of channels, as that would keep all ESLint related discussions in 1 server and we can easily link people to the right channel that way.
Having the community core group responsible for creating these channels would be a good idea imo, as this way it won't create extra work for the ESLint TSC.
I think that having a separate channel for each package would be easiest for people to talk about things regarding that specific package. This also makes sure that these discussions don't pollute other packages' discussions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you update the TFC with this?
I think we should probably just start with one channel for the community core team and worry about whether packages need their own channels later. I’m guessing most won’t have an active need for it.