Repository navigation
Bugfix/nand read errors - #37
Merged
Merged
Conversation
wait_for_ready() checked the deadline only after a BUSY status read. A task preempted right after that read resumed past the 2-tick bound at 100 Hz and reported a timeout although the 25 us page load had already finished, failing IDEA downloads with read errors. Sample the elapsed ticks before each STATUS read, so a timeout now requires a read issued after the deadline to still see BUSY, and log the actual wait instead of the configured bound.
The chip and device ID error logs printed a local ret that was always ESP_OK. With silent assertion checks the log arguments are dropped and the variable triggers -Wunused-variable in every application build. Drop the variable and its format argument; the macro still returns the real error. Record the upstream hashes of the touched device sources.
A failed physical read latched an error that only a remount or format cleared. Applications that stay mounted kept reporting the media as faulty until reboot, even after a transient error. Add mosaico_nand_storage_clear_error() to forget the latch while the volume is mounted. A persistent fault latches again on its next failed read. Bump the component to 0.2.0 for the new public API and use the standard copyright header in the touched files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.