esp-radio: Rename scan_with_config_async to scan_async#4946
Merged
JurajSadel merged 5 commits intoesp-rs:mainfrom Feb 11, 2026
Merged
esp-radio: Rename scan_with_config_async to scan_async#4946JurajSadel merged 5 commits intoesp-rs:mainfrom
scan_with_config_async to scan_async#4946JurajSadel merged 5 commits intoesp-rs:mainfrom
Conversation
bugadani
reviewed
Feb 9, 2026
JurajSadel
force-pushed
the
radio-api
branch
2 times, most recently
from
8754320 to
a745273
Compare
JurajSadel
force-pushed
the
radio-api
branch
from
a745273 to
431a13b
Compare
MabezDev
approved these changes
Feb 11, 2026
Member
MabezDev
left a comment
MabezDev
left a comment
There was a problem hiding this comment.
LGTM with a rebase, nice catch - thanks!
Member
|
Rebase gone wrong here, I think. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we don't have a version variant without a
configthe name is a bit weird.cc #4712