Only allow supported ESP-IDF targets#125
Merged
SergioGasquez merged 1 commit intoesp-rs:masterfrom Jun 12, 2023
sredman:work/sredman/fix-default-esp-idf
Merged
Only allow supported ESP-IDF targets#125SergioGasquez merged 1 commit intoesp-rs:masterfrom sredman:work/sredman/fix-default-esp-idf
SergioGasquez merged 1 commit intoesp-rs:masterfrom
sredman:work/sredman/fix-default-esp-idf
Conversation
Contributor
Author
|
Support matrix here: https://github.com/espressif/esp-idf#esp-idf-release-and-soc-compatibility |
This was referenced Jun 11, 2023
Merged
Contributor
Author
|
Tested end-to-end on my esp32c6 devboard: I can create a fresh project, build, flash, and see "Hello World". I have to edit the targets in the |
SergioGasquez
approved these changes
Jun 12, 2023
Member
SergioGasquez
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion on #123
Only allow the user to select ESP-IDF targets which support the selected MCU.
This should work without #124, even though some of the MCU targets don't exist until that is merged.