Skip to content

Adding guition JC4480#1692

Open
widget wants to merge 6 commits into
esphome:mainfrom
widget:feature/new-device-guition-jc4480
Open

Adding guition JC4480#1692
widget wants to merge 6 commits into
esphome:mainfrom
widget:feature/new-device-guition-jc4480

Conversation

@widget

@widget widget commented Jun 27, 2026

Copy link
Copy Markdown

Brief description of the changes

Adding this Guition board

Type of changes

  • New device (a single device only — one device per pull request)
  • Update existing device
  • Removing a device
  • General cleanup
  • Other

Checklist:

The rules below are enforced in CI by npm run validate-devices and npm run validate-yaml. The full reference is at Configuration YAML files.

  • Adding a new device adds a single device only — one device per pull request.
  • Each example yaml lives in its own .yaml file alongside index.md and is pulled into the page with a fenced block of the form ```yaml file=<name>.yaml — no inline yaml on added or modified pages.
  • The first file= fence on the page references config.yaml.
  • config.yaml is hardware-only: no top-level api:, ota:, mqtt:, web_server:, web_server_idf:, improv_serial:, captive_portal:, bluetooth_proxy:, or dashboard_import:, and no platform: homeassistant, platform: mqtt, or platform: template anywhere in the tree.
  • If config.yaml has a wifi: block, it contains only radio tunables (country, power_save_mode, output_power, …) — no ssid, password, networks, manual_ip, eap, or use_address. An empty ap: block is allowed.
  • No passwords (literal or !secret) on password:, *_password:, or psk: keys, and no !secret references anywhere in any example yaml.
  • For pages with made-for-esphome: true in frontmatter: at least one ```yaml url=… fence points at a .yaml file in the manufacturer's GitHub repo (github.com/<owner>/<repo>/(blob|raw)/<ref>/<path>.yaml or the raw.githubusercontent.com equivalent) so the rendered page shows the upstream config live.

@netlify

netlify Bot commented Jun 27, 2026

Copy link
Copy Markdown

Deploy Preview for esphome-devices ready!

Name Link
🔨 Latest commit 44f09b3
🔍 Latest deploy log https://app.netlify.com/projects/esphome-devices/deploys/6a3ffdbf937e2d0008fa1d95
😎 Deploy Preview https://deploy-preview-1692--esphome-devices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

esphome[bot]
esphome Bot previously requested changes Jun 27, 2026

@esphome esphome Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Device configuration checks failed

The automated checks for the device pages in this pull request found 1 issue. Please address the items below and push an update — this review refreshes automatically and will be dismissed once the checks pass.

src/docs/devices/guition-jc4480p443c/config.yaml

  • line 35 — invalid yaml: unknown tag !<!include>

Need help? See the Adding Devices guide.

@esphome
esphome Bot marked this pull request as draft June 27, 2026 16:37
@esphome

esphome Bot commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@esphome
esphome Bot dismissed their stale review June 27, 2026 16:40

Device configuration checks now pass — dismissing.

@widget
widget marked this pull request as ready for review June 27, 2026 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant