Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SLU models #56

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add SLU models #56

wants to merge 7 commits into from

Conversation

siddhu001
Copy link

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2021

Codecov Report

Merging #56 (03bbd39) into master (8b73019) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   50.76%   50.76%           
=======================================
  Files           2        2           
  Lines         390      390           
=======================================
  Hits          198      198           
  Misses        192      192           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@siddhu001
Copy link
Author

@ftshijt Do you know how I can fix this issue?

@sw005320
Copy link
Collaborator

Are these models using s3prl?
If so, the test should include it in the installation stage.

It is a little bit difficult decision as we want to make espnet_model_zoo installation as light as possible.
But anyway, can you first try it?

@siddhu001
Copy link
Author

siddhu001 commented Nov 17, 2021

They do use s3prl. Sure I will do that!

@sw005320
Copy link
Collaborator

Can you fix the conflict?

@siddhu001
Copy link
Author

Sure! I will work on it now!

@siddhu001
Copy link
Author

I think the earlier error due to ASR streaming model has been fixed now with the help of previously merged pull request - #57.

I have fixed the import ordering. I think after this pull request is merged - espnet/espnet#3928, the test should hopefully pass.

@siddhu001
Copy link
Author

The issue seems to be connected to facebookresearch/fairseq#1400. There seems to be some issue with pytorch hub cache. I will try using workaround mentioned in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants