Clean up and update the project for readability and best practices#7
Merged
Clean up and update the project for readability and best practices#7
Conversation
Clean up and update the project for readability, best practices, and using React and Tiptap example. * **Remove obsolete files and references:** - Delete `macos-editor/renderer.js`. - Delete `macos-editor/src/index.jsx`. - Delete `macos-editor/splash.html`. - Remove reference to `renderer.js` in `macos-editor/index.html`. - Remove `preload.js` reference from `webPreferences` in `macos-editor/main.js`. - Remove `createSplashWindow` function and its references in `macos-editor/main.js`. * **Refactor and update code:** - Refactor `createWindow` function to use async/await in `macos-editor/main.js`. - Update Tiptap extensions and add a toolbar with buttons for Tiptap commands in `macos-editor/src/index.tsx`. * **Update dependencies and scripts:** - Update dependencies in `macos-editor/package.json` to align with the Tiptap example. - Update scripts in `macos-editor/package.json` to use `tsc` and `esbuild` for building the project. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/espora-net/pora/tree/main?shareId=XXXX-XXXX-XXXX-XXXX).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up and update the project for readability, best practices, and using React and Tiptap example.
Remove obsolete files and references:
macos-editor/renderer.js.macos-editor/src/index.jsx.macos-editor/splash.html.renderer.jsinmacos-editor/index.html.preload.jsreference fromwebPreferencesinmacos-editor/main.js.createSplashWindowfunction and its references inmacos-editor/main.js.Refactor and update code:
createWindowfunction to use async/await inmacos-editor/main.js.macos-editor/src/index.tsx.Update dependencies and scripts:
macos-editor/package.jsonto align with the Tiptap example.macos-editor/package.jsonto usetscandesbuildfor building the project.For more details, open the Copilot Workspace session.