Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Zigbee): Adding Zigbee Wind speed sensor example #10455

Draft
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Oct 13, 2024

Zigbee Wind speed sensor example

By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes

Checklist

  1. Please provide specific title of the PR describing the change, including the component name (eg. „Update of Documentation link on Readme.md“)
  2. Please provide related links (eg. Issue which will be closed by this Pull Request)
  3. Please update relevant Documentation if applicable
  4. Please check Contributing guide
  5. Please confirm option to "Allow edits and access to secrets by maintainers" when opening a Pull Request

This entire section above can be deleted if all items are checked.


Description of Change

Please describe your proposed Pull Request and it's impact.

Tests scenarios

Please describe on what Hardware and Software combinations you have tested this Pull Request and how.

(eg. I have tested my Pull Request on Arduino-esp32 core v2.0.2 with ESP32 and ESP32-S2 Board with this scenario)

Related links

esp-zigbee-sdk: Add HA standard wind speed sensor device default config value #451

Copy link
Contributor

github-actions bot commented Oct 13, 2024

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Create ZigbeeWindSpeedSensor.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Create ZigbeeWindSpeedSensor.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Create ZigbeeWindSpeedSensor.ino":
    • summary looks empty
    • type/action looks empty
  • the commit message "Create ci.json":
    • summary looks empty
    • type/action looks empty
  • the commit message "Rename ZigbeeWindSpeedSensor.ino to Zigbee_Wind_Speed_Sensor.ino":
    • summary looks empty
    • type/action looks empty
  • the commit message "Rename ci.json to ci.json":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update CMakeLists.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ZigbeeWindSpeedSensor.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ZigbeeWindSpeedSensor.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ZigbeeWindSpeedSensor.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ZigbeeWindSpeedSensor.cpp":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ZigbeeWindSpeedSensor.ino":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update ZigbeeWindSpeedSensor.ino":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update Zigbee_Wind_Speed_Sensor.ino":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update Zigbee_Wind_Speed_Sensor.ino":
    • summary looks empty
    • type/action looks empty
  • the commit message "Update Zigbee_Wind_Speed_Sensor.ino":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️ Please consider squashing your 17 commits (simplifying branch history).
⚠️

The source branch "WindSpeedSensor" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.

👋 Hello lboue, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against 87c438e

Copy link
Contributor

github-actions bot commented Oct 13, 2024

Test Results

 56 files   56 suites   4m 12s ⏱️
 21 tests  21 ✅ 0 💤 0 ❌
134 runs  134 ✅ 0 💤 0 ❌

Results for commit 87c438e.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Oct 14, 2024

@lboue If you need any help let me know. We can also open a private chat on any platform :)
I am really happy to see adding new endpoint!

@lboue
Copy link
Contributor Author

lboue commented Oct 14, 2024

@P-R-O-C-H-Y Can I write to you on Discord?

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Oct 14, 2024

@P-R-O-C-H-Y Can I write to you on Discord?

@lboue Sure, find me under #prochyesp

@lboue
Copy link
Contributor Author

lboue commented Oct 15, 2024

@P-R-O-C-H-Y Can I write to you on Discord?

@lboue Sure, find me under #prochyesp

In which discord server?

@P-R-O-C-H-Y
Copy link
Member

P-R-O-C-H-Y commented Oct 15, 2024

@P-R-O-C-H-Y Can I write to you on Discord?

@lboue Sure, find me under #prochyesp

In which discord server?

No need for discord server, just PM me on Discord.

Use ESP_ZB_HA_SIMPLE_SENSOR_DEVICE_ID device id
@VojtechBartoska VojtechBartoska changed the title Zigbee Wind speed sensor example feat(Zigbee): Zigbee Wind speed sensor example Nov 4, 2024
@VojtechBartoska VojtechBartoska changed the title feat(Zigbee): Zigbee Wind speed sensor example feat(Zigbee): Adding Zigbee Wind speed sensor example Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: In Progress Issue is in progress Type: Example Issue is related to specific example.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants