Bugfix/improve event handling path timing - #168
Open
alisitsyn wants to merge 2 commits into
Open
Conversation
3 tasks
3 tasks
alisitsyn
force-pushed
the
bugfix/improve_event_handling_path_timing
branch
from
April 16, 2026 13:32
98d686f to
ce3d60e
Compare
alisitsyn
force-pushed
the
bugfix/improve_event_handling_path_timing
branch
from
April 30, 2026 10:42
ce3d60e to
37dd099
Compare
|
I hope to promote the code version for easy testing and use as soon as possible |
Collaborator
Author
|
In order to check the issue we need the example code to reproduce issue on both sides with existing environments (base standpoint). As I said the communication timings depend on many aspects and I have different results on my side (wifi for now). If you can, please publish your simplified project which can be used for verification and the sdkconfig file. I will take a look ASAP. Thanks. |
|
@alisitsyn Ok, I will try to streamline the project and achieve its objectives. Please hold on while I upload the complete version of my current project first |
|
ESP32S3-M0001.zip |
alisitsyn
force-pushed
the
bugfix/improve_event_handling_path_timing
branch
from
May 13, 2026 12:08
37dd099 to
b3b7066
Compare
alisitsyn
force-pushed
the
bugfix/improve_event_handling_path_timing
branch
from
July 1, 2026 09:22
b3b7066 to
bff8193
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This MR addresses the throughput issues in Modbus TCP Slave. The investigation of timing aspects in the loop is performed as part of this PR. The event loop has been improved to decrease gap time between reading of different registers when more events (IO + sock events) are happened with multi-master connections. Different events can be processed sequentially avoiding additional time gaps with the select() timeouts. Additional kconfig values are added for fine tune of the TCP event loop processing.
Related
Fixes: EPROT-50
Related: EPROT-55
Testing
The testing is performed manually with four masters connected to the same ESP32 Modbus TCP Slave. The event loop related parameters and their impact to overall processing are investigated and moved to kconfig configuration allowing better turning in user applications.
Checklist
Before submitting a Pull Request, please ensure the following: