fix: master tcp reconnection issue - #173
Draft
alisitsyn wants to merge 2 commits into
Draft
Conversation
alisitsyn
force-pushed
the
bugfix/fix_master_tcp_reconnection_issue
branch
from
May 21, 2026 07:44
4e74762 to
84c1f8d
Compare
alisitsyn
marked this pull request as draft
May 21, 2026 07:46
3 tasks
alisitsyn
force-pushed
the
bugfix/fix_master_tcp_reconnection_issue
branch
from
May 21, 2026 10:08
68891d5 to
dd25e20
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue of Modbus TCP Master to reestablish connection with the slave node as soon as possible. Current TCP Master supposed that all slaves should be available on starting connection phase and did not repair connection when connection error exists.
The above issue has been reproduced and confirmed as bug with IP101 Ethernet board. The
port_tcp_master.chas been updated to repair connection cycle as soon as possible if the errors exist.Related
Fixes EPROT-62 - #167
Testing
port_tcp_master.chas been updated to repair connection cycle as soon as possible if the errors exist.In the above cases the TCP Master was able to establish connections as soon as possible and proceed with polling cycle correctly.
Checklist