Skip to content

feat(websocket): Create specific Event for PONG message #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat(websocket): Create specific Event for PONG message #874

wants to merge 1 commit into from

Conversation

glmfe
Copy link
Collaborator

@glmfe glmfe commented Aug 26, 2025 •
edited
Loading

Description

  • Separate the PONG message from generic payload, this can make it easier to identify when a timeout occur when receiving a payload

Related

@glmfe glmfe force-pushed the feat/add-pong-event branch 3 times, most recently from 861cb66 to 7449284 Compare August 27, 2025 13:55
@glmfe glmfe self-assigned this Aug 28, 2025
@glmfe glmfe marked this pull request as ready for review August 28, 2025 10:34
david-cermak
david-cermak approved these changes Aug 28, 2025
View reviewed changes
Copy link
Collaborator

@david-cermak david-cermak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just few questions/optional comments

@glmfe glmfe force-pushed the feat/add-pong-event branch from 7449284 to 0976e3c Compare September 1, 2025 18:54
@euripedesrocha
Copy link
Collaborator

I believe this should be marked as a breaking change. Although the event is new, how the users were dealing with the PONG message before?

@Lupindakaas Lupindakaas mentioned this pull request Sep 3, 2025
Open
3 tasks
@glmfe
Copy link
Collaborator Author

glmfe commented Sep 3, 2025 •
edited
Loading

@euripedesrocha

I believe this should be marked as a breaking change. Although the event is new, how the users were dealing with the PONG message before?

From all the context I've got they were all being handled at the "WEBSOCKET_EVENT_DATA" or ignored, have no inputs on if they were also handled in an app level... But yes, this might be a breaking change.

@glmfe glmfe mentioned this pull request Sep 19, 2025
Open
@glmfe
feat(websocket): Create specific Event for PONG message
881e2e8 
- Separate the PONG message from generic payload, this can make it easier to identify when a timeout occur when receiving a payload
@glmfe glmfe force-pushed the feat/add-pong-event branch from 0976e3c to 881e2e8 Compare September 19, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@david-cermak david-cermak david-cermak approved these changes

@euripedesrocha euripedesrocha Awaiting requested review from euripedesrocha

Assignees

@glmfe glmfe

Labels

websocket

Projects

None yet

Milestone

No milestone

3 participants

@glmfe @euripedesrocha @david-cermak