Skip to content

Conversation

david-cermak
Copy link
Collaborator

@david-cermak david-cermak commented May 30, 2025

  • Parse supplicant related headers and generate
    • remote eap-client headers
    • impl translating eap-client APIs -> remote APIs
    • __weak impl of the remote APIs
  • some support scripts
  • tests

Closes #19

@david-cermak david-cermak self-assigned this May 30, 2025
@david-cermak david-cermak force-pushed the feat/eap_prototypes branch 2 times, most recently from 036a7e7 to c367706 Compare May 30, 2025 13:57
@david-cermak david-cermak requested a review from kapilkedawat May 30, 2025 14:50
@david-cermak david-cermak force-pushed the feat/eap_prototypes branch from ee14cd6 to c8d1052 Compare June 2, 2025 09:10
orsource "./idf_v$ESP_IDF_VERSION/Kconfig.soc_wifi_caps.in"
orsource "./Kconfig.rpc.in"

config ESP_WIFI_REMOTE_EAP_ENABLED
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need this config? Also this needs to be dependent of ESP_WIFI_ENTERPRISE_SUPPORT(compilation will still pass due to weak links but functionality wise we should make it dependent.)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also this needs to be dependent of ESP_WIFI_ENTERPRISE_SUPPORT

Added dependency to WIFI_RMT_ENTERPRISE_SUPPORT (the same slave related option)

do we need this config?

I'd prefer that we keep this option, since it bring PUBLIC dependency to wpa_supplicant (which we might like to avoid for most cases IMO)

@kapilkedawat
Copy link
Collaborator

@Shreyas0-7 could you try eap changes with this MR?

@david-cermak david-cermak force-pushed the feat/eap_prototypes branch 2 times, most recently from 03dc813 to fc608cc Compare June 2, 2025 11:42
@david-cermak
Copy link
Collaborator Author

@kapilkedawat Thanks for the quick review! I've added a CI check to build the enterprise example for P4, H2 and S3.
(CI passed previously on 03dc813, now I only cleaned-up the history)

@Shreyas0-7 could you try eap changes with this MR?

Note: this is just API addition, so you'd probably see an abort() after the

ESP_ERROR_CHECK(esp_eap_client_set_identity(...));

as the weak implementation would be pulled

@Shreyas0-7
Copy link

Hey @david-cermak, thank you, will check

@kapilkedawat
Copy link
Collaborator

@david-cermak The changes looks generally good to me..

However some points regarding both esp-remote and esp-mcu, do we actually need to add new config options for these components? IMO these configuration should somehow be derived from esp-idf's sdkconfig, so that user have the same experience as using esp-idf native WiFi.

@kapilkedawat
Copy link
Collaborator

Also @Shreyas0-7 is currently testing wifi enterprise using this, will update once he is done(we already have a working eap, will just sync changes and see if there is any difference).

@david-cermak
Copy link
Collaborator Author

@kapilkedawat

do we actually need to add new config options for these components?

You mean the WIFI_RMT_... (in wifi-remote component) vs those ESP_WIFI_... from esp_wifi? There are mainly for the coexistence of local and remote Wi-Fi(e.g. if someone wants to use native esp_wifi_connect()on S3 and at the same timeesp_wifi_remote_connect()` on the slave target, like C5)

@david-cermak david-cermak force-pushed the feat/eap_prototypes branch from 9fcbdac to 30944fc Compare June 11, 2025 15:44
@kapilkedawat
Copy link
Collaborator

kapilkedawat commented Jun 20, 2025

Hi @david-cermak , Please help to merge this, we have verified this internally.

@david-cermak david-cermak force-pushed the feat/eap_prototypes branch from 30944fc to 2063b1b Compare June 20, 2025 10:56
@david-cermak david-cermak force-pushed the feat/eap_prototypes branch from 2063b1b to ffe2af7 Compare June 20, 2025 11:49
0.13.0
Features
- Add support for EAP client API (ffe2af7)
Bug Fixes
- Regenerate all files with EAP client support (1d39117)
@david-cermak
Copy link
Collaborator Author

Please help to merge this, we have verified this internally.

Thanks for testing the changes. Okay, I will merge and publish the updates.

Note that the WIFI_RMT_ENTERPRISE_SUPPORT option is ON by deafult

@david-cermak david-cermak merged commit 77deec1 into espressif:main Jun 20, 2025
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for esp_eap_client_* and esp_wifi_sta_enterprise_* APIs (IDFGH-14678)
3 participants