-
Notifications
You must be signed in to change notification settings - Fork 3
Support for EAP client API #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for EAP client API #42
Conversation
036a7e7
to
c367706
Compare
components/esp_wifi_remote/idf_tag_v5.3.1/esp_eap_client_remote_weak.c
Outdated
Show resolved
Hide resolved
components/esp_wifi_remote/idf_tag_v5.3.1/esp_eap_client_remote_weak.c
Outdated
Show resolved
Hide resolved
components/esp_wifi_remote/idf_tag_v5.3.1/esp_eap_client_remote_weak.c
Outdated
Show resolved
Hide resolved
ee14cd6
to
c8d1052
Compare
orsource "./idf_v$ESP_IDF_VERSION/Kconfig.soc_wifi_caps.in" | ||
orsource "./Kconfig.rpc.in" | ||
|
||
config ESP_WIFI_REMOTE_EAP_ENABLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this config? Also this needs to be dependent of ESP_WIFI_ENTERPRISE_SUPPORT
(compilation will still pass due to weak links but functionality wise we should make it dependent.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this needs to be dependent of ESP_WIFI_ENTERPRISE_SUPPORT
Added dependency to WIFI_RMT_ENTERPRISE_SUPPORT
(the same slave related option)
do we need this config?
I'd prefer that we keep this option, since it bring PUBLIC dependency to wpa_supplicant
(which we might like to avoid for most cases IMO)
@Shreyas0-7 could you try eap changes with this MR? |
03dc813
to
fc608cc
Compare
@kapilkedawat Thanks for the quick review! I've added a CI check to build the enterprise example for P4, H2 and S3.
Note: this is just API addition, so you'd probably see an ESP_ERROR_CHECK(esp_eap_client_set_identity(...)); as the weak implementation would be pulled |
Hey @david-cermak, thank you, will check |
@david-cermak The changes looks generally good to me.. However some points regarding both esp-remote and esp-mcu, do we actually need to add new config options for these components? IMO these configuration should somehow be derived from esp-idf's sdkconfig, so that user have the same experience as using esp-idf native WiFi. |
Also @Shreyas0-7 is currently testing wifi enterprise using this, will update once he is done(we already have a working eap, will just sync changes and see if there is any difference). |
You mean the |
9fcbdac
to
30944fc
Compare
Hi @david-cermak , Please help to merge this, we have verified this internally. |
30944fc
to
2063b1b
Compare
2063b1b
to
ffe2af7
Compare
Thanks for testing the changes. Okay, I will merge and publish the updates. Note that the |
__weak
impl of the remote APIsCloses #19