Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spi_nand_flash): Add data refresh threshold for ECC correction #437

Conversation

RathiSonika
Copy link
Collaborator

Change description

Currently, spi_nand_flash_read_sector() rewrites the sector without considering the number of bits corrected by ECC.

In this PR, a Kconfig option has been added to configure the data refresh threshold at runtime, allowing the decision on whether a data refresh is needed to be based on this threshold and number of bits corrected by ECC

@RathiSonika RathiSonika force-pushed the feat/nand_flash_add_refresh_threshold branch from ea6c348 to 21f6e2f Compare November 1, 2024 09:00
@RathiSonika RathiSonika marked this pull request as ready for review November 4, 2024 08:15
Copy link
Member

@igrr igrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment about error handling, LGTM otherwise!

@RathiSonika RathiSonika force-pushed the feat/nand_flash_add_refresh_threshold branch from ca84d14 to c652413 Compare November 4, 2024 17:29
@RathiSonika RathiSonika force-pushed the feat/nand_flash_add_refresh_threshold branch from c652413 to 53cfdc9 Compare November 5, 2024 08:18
@RathiSonika RathiSonika merged commit bb6abc0 into espressif:master Nov 5, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants