-
Notifications
You must be signed in to change notification settings - Fork 2
[EIM-300] [Test] Add version management UI test #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Standardize EIM path Variable name
Summary of ChangesHello @Fabricio-ESP, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the test coverage for the application's version management capabilities, specifically focusing on the Graphical User Interface (GUI). It introduces a dedicated test suite to validate core functionalities such as renaming, deleting, and purging installed versions, ensuring these critical operations work as expected. Additionally, the PR includes several under-the-hood improvements to existing test infrastructure, such as standardizing variable naming conventions and fine-tuning test timeouts, which collectively contribute to more stable and reliable automated testing. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces UI tests for the version management features and includes several improvements to the existing test suite. The changes are generally positive, enhancing test stability by increasing timeouts and improving variable scoping. The new test file for GUI version management is well-structured. However, I've identified a bug in one of the test assertions and a few instances of fragile selectors that could lead to flaky tests. I've also pointed out some minor code style issues and a naming inconsistency in one of the test suite configuration files. Addressing these points will improve the robustness and maintainability of the test suite.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the change. Just small nitpick here.
Description
This PR introduces the basic test for the version management features over the GUI.
The functions for rename delete and purge are now tested as part of the workflow.
The buttons to launch an external terminal instance or open the IDF folder location cannot be easily tested as it launches a system window rather than an interface on EIM.
The fix installation feature can be implemented later, but since this is a reinstallation feature, it will be tested once other re-installation test sequences are added.
Also as part of this PR, some improvements were done, as adjusting and isolating test variables names, preventing errors with variable being declared multiple times.
Timeouts were also adjusted on several tests to improve stability of the tests.
Related
Testing
Checklist
Before submitting a Pull Request, please ensure the following: