Skip to content

Conversation

@Fabricio-ESP
Copy link
Collaborator

Description

This PR introduces the basic test for the version management features over the GUI.
The functions for rename delete and purge are now tested as part of the workflow.

The buttons to launch an external terminal instance or open the IDF folder location cannot be easily tested as it launches a system window rather than an interface on EIM.

The fix installation feature can be implemented later, but since this is a reinstallation feature, it will be tested once other re-installation test sequences are added.

Also as part of this PR, some improvements were done, as adjusting and isolating test variables names, preventing errors with variable being declared multiple times.
Timeouts were also adjusted on several tests to improve stability of the tests.

Related

Testing


Checklist

Before submitting a Pull Request, please ensure the following:

  • 🚨 This PR does not introduce breaking changes.
  • All CI checks (GH Actions) pass.
  • Documentation is updated as needed.
  • Tests are updated or added as necessary.
  • Code is well-commented, especially in complex areas.
  • Git history is clean — commits are squashed to the minimum necessary.

@Fabricio-ESP Fabricio-ESP added the EXTENDEDTEST Run extended auto tests and mirrors test label Oct 28, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @Fabricio-ESP, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the test coverage for the application's version management capabilities, specifically focusing on the Graphical User Interface (GUI). It introduces a dedicated test suite to validate core functionalities such as renaming, deleting, and purging installed versions, ensuring these critical operations work as expected. Additionally, the PR includes several under-the-hood improvements to existing test infrastructure, such as standardizing variable naming conventions and fine-tuning test timeouts, which collectively contribute to more stable and reliable automated testing.

Highlights

  • New GUI Version Management Tests: A comprehensive UI test suite has been introduced to validate the version management features of the GUI, specifically covering the renaming, deleting, and purging of installed versions.
  • Test Stability Improvements: Existing tests have been made more robust by adjusting various timeouts and standardizing variable names (e.g., pathToEim to pathToEIM) across multiple test files, which helps prevent conflicts and improves readability.
  • Refactored Test Runners: Several GUI test runner scripts have been updated to ensure proper test state management and resource cleanup, including explicit nulling of runner instances and flags for skipping tests upon failure.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces UI tests for the version management features and includes several improvements to the existing test suite. The changes are generally positive, enhancing test stability by increasing timeouts and improving variable scoping. The new test file for GUI version management is well-structured. However, I've identified a bug in one of the test assertions and a few instances of fragile selectors that could lead to flaky tests. I've also pointed out some minor code style issues and a naming inconsistency in one of the test suite configuration files. Addressing these points will improve the robustness and maintainability of the test suite.

Copy link
Collaborator

@Hahihula Hahihula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the change. Just small nitpick here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EXTENDEDTEST Run extended auto tests and mirrors test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants