Skip to content

Conversation

@Hahihula
Copy link
Collaborator

@Hahihula Hahihula commented Oct 31, 2025

there was text duplication in GUI
image

... is now removed
image
.. and the link is moved below the form

@gemini-code-assist
Copy link

Summary of Changes

Hello @Hahihula, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor UI issue by removing a duplicated text string from the graphical user interface. The change ensures that the 'Product Selector' link is displayed only once, improving the clarity and conciseness of the user experience in the target selection wizard.

Highlights

  • GUI Text Duplication Removed: Eliminated a redundant 'Product Selector' text string that was appearing twice in the GUI, specifically within the target selection wizard step.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes a duplicated 'Product Selector' string from the UI by relying on the internationalization key. This fixes a visual bug and improves code maintainability. I've added one suggestion to improve security by adding rel="noopener noreferrer" to the link that opens in a new tab.

<p class="description" data-id="target-select-description-second-line">{{ t('targetSelect.productSelectorMessage') }} <a
href="https://products.espressif.com/#/product-comparison?names=ESP32-S2,ESP32-C3,ESP32-S3,ESP32-C6&type=SoC"
target="_blank">{{ t('targetSelect.productSelector') }}Product Selector</a></p>
target="_blank">{{ t('targetSelect.productSelector') }}</a></p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For security reasons, when using target="_blank", it's a good practice to also add rel="noopener noreferrer". This prevents the new page from being able to access window.opener and protects against potential phishing attacks.

        target="_blank" rel="noopener noreferrer">{{ t('targetSelect.productSelector') }}</a></p>

Copy link
Collaborator

@kolipakakondal kolipakakondal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@Fabricio-ESP Fabricio-ESP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants