fix: close relays at startup after we load config

[mtfurlan]

If you aren't using OFFICIALBOARD and your relay isn't active high on
pin 13 it will be left open on startup.

I feel like this is inconsistant because I thought it was working a few days ago
but all the commits I might have had running don't lock my test door controller,
so I dunno.

[matjack1]

isn't this happening already here: https://github.com/esprfid/esp-rfid/blob/dev/src/config.esp#L166 ?

[mtfurlan]

Oh interesting.
It looks like my problem is that I have the official board so I am compiling with -DOFFICIALBOARD, but my relay needs to be asserted high to lock the door.
So the bug is just that if your lock is active high on the official board it doesn't lock.
The inconsistency I saw is probably that I was compiling with and without OFFICIALBOARD at different times.

Is there any reason that shouldn't happen there regardless of if it is an OFFICIALBOARD?

What is the reasoning behind the OFFICIALBOARD stuff?
I had expected that it just defaults some things like which pin is the relay pin, but it appears to do a lot more.

[matjack1]

I'm not 100% sure how the official board works unfortunately, but it's a custom PCB with specific components. So if you have the official board you don't need to setup anything, it's all ready with zero configuration. If you have any other compatible hardware you shouldn't use the OFFICIALBOARD flag. Makes sense?

[mtfurlan]

I have the PCB in the images in the readme from the tindie store.
I set the relay to "active low".
If I compile with -DOFFICIALBOARD then it doesn't lock on boot, if I don't compile with it it does lock on boot.

We could remove the #ifndef OFFICIALBOARD around the code you linked and it would boot up as I expected, though I feel like I'm missing something about how OFFICIALBOARD is supposed to be used.
It assumes stuff like having a wiegand reader connected, so maybe OFFICIALBOARD is supposed to be the PCB with a specific set of stuff connected that works in a specific way, such as an active high relay and a wiegand reader and in that case we should leave it alone?

Either way I think I'm going to not compile with -DOFFICIALBOARD again so it doesn't ignore configuration stuff.

[matjack1]

Now that I'm checking the board, I can see that the old version supports only the Wiegand and the new one also other readers.

I'm not sure if @nardev is reading us, but probably we can drop the OFFICIALBOARD code with the new board, as it's customizable and it doesn't make sense anymore. @omersiar what do you think? It would make the code much nicer and easier! :)

[nardev]

@matjack1 you are right!

[matjack1]

Thank you @nardev for confirming! I might try getting rid of the OFFICIALBOARD flag and simplify everything a bit then ;)

[nardev]

I also have several different hardware versions and it's quite hard to maintain it. At the moment I think making separate, custom config files could make things easier or even make whole list of default values in separate h files and just a simple switch in the begging to choose the list of default common values.. Either way, the UI should be as same as possible. It's just pain yo maintain it otherwise.

…

On Fri, Jul 15, 2022, 10:12 AM Matteo Giaccone ***@***.***> wrote: Thank you @nardev <https://github.com/nardev> for confirming! I might try getting rid of the OFFICIALBOARD flag and simplify everything a bit then ;) — Reply to this email directly, view it on GitHub <#526 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFJ55RFY6RDVRACLU4HDWDVUEMM5ANCNFSM527WDDUA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[matjack1]

It's good to know that you are still using the project!

We could think about shipping some configs that you can pick from the UI maybe? So you can pick the settings the first time? When I'll play around to remove the build flag I'll try something out and let you know!

[nardev]

That would be a great first move if you can...

…

On Fri, Jul 15, 2022 at 10:22 AM Matteo Giaccone ***@***.***> wrote: It's good to know that you are still using the project! We could think about shipping some configs that you can pick from the UI maybe? So you can pick the settings the first time? When I'll play around to remove the build flag I'll try something out and let you know! — Reply to this email directly, view it on GitHub <#526 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFJ55U3NXSPTBH55T6GQU3VUENT7ANCNFSM527WDDUA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

-- Vedran Alajbegovic skype: vedran.alajbegovic mob: +38761107423

[matjack1]

I've added this issue: #545 to track what's still needed.

I'm going to close this PR as this should not be needed anymore, OK?

Let me know if I'm wrong though :)