Skip to content

chore: modernize tooling and improve code organization - #30

Closed
essinghigh wants to merge 1 commit into
mainfrom
modernize-tooling-17052123235656541966
Closed

essinghigh wants to merge 1 commit into
mainfrom
modernize-tooling-17052123235656541966

Conversation

@essinghigh

Copy link
Copy Markdown
Member

This submission aims to improve the codebase structure and modernize it using standard Grafana tools.

  1. Tooling Migration: Executed npx @grafana/create-plugin@latest update to conform to modern Grafana plugin standards. Upgraded dependencies to surface any incompatibilities and transitioned away from manual Webpack configurations to standardized scripts.
  2. CI Simplification: Refactored the GitHub Actions ci.yml. Removed the logic that explicitly skipped pushes to main which weren't merge commits. Removed plugin signing because it will not be used in this repository.
  3. Code Organization:
    • Extracted the massive HTTP orchestration logic from datasource.ts into a standalone SplunkClient.ts.
    • Moved boilerplate and helper functions into utils/searchHelpers.ts.
    • Split a large portion of QueryEditor.tsx's render logic into QueryEditorConfig.tsx.
    • Ensure yarn test:ci, yarn build, and yarn lint are all fully operational with the new structure.

PR created automatically by Jules for task 17052123235656541966 started by @essinghigh

- Migrated to standard `@grafana/create-plugin` setup via the `update` command.
- Removed unused custom webpack scripts and configurations.
- Streamlined GitHub Actions `ci.yml` to build and release seamlessly on pushes to main.
- Split up `src/datasource.ts` by extracting API logic into `SplunkClient` and utility helpers.
- Refactored `QueryEditor.tsx` by breaking down configuration UI into a separate component.
- Fixed failing unit tests and correctly wired up mocking for `SplunkClient`.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@essinghigh

Copy link
Copy Markdown
Member Author

Personally not a fan of the way Jules writes code. I'll handle this myself.

@essinghigh essinghigh closed this Jul 26, 2026
@essinghigh
essinghigh deleted the modernize-tooling-17052123235656541966 branch July 26, 2026 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant