Skip to content

Commit

Permalink
Added support for BigInt and Numeric Separators
Browse files Browse the repository at this point in the history
  • Loading branch information
sanex3339 committed Aug 20, 2020
1 parent ab53cd5 commit 92c067e
Show file tree
Hide file tree
Showing 9 changed files with 134 additions and 1 deletion.
10 changes: 10 additions & 0 deletions escodegen.js
Original file line number Diff line number Diff line change
Expand Up @@ -2356,7 +2356,17 @@
return escapeString(expr.value);
}

// BigInt, eg: 1n
if (typeof expr.bigint === 'string' && expr.raw) {
return expr.raw;
}

if (typeof expr.value === 'number') {
// Has Numeric Separator
if (expr.raw && expr.raw.indexOf('_') !== -1) {
return expr.raw;
}

return generateNumber(expr.value);
}

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"source-map": "~0.6.1"
},
"devDependencies": {
"acorn": "^7.3.1",
"acorn": "^8.0.1",
"bluebird": "^3.4.7",
"bower-registry-client": "^1.0.0",
"chai": "^4.2.0",
Expand Down
6 changes: 6 additions & 0 deletions test/compare-acorn-es2020/bigint.expected.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
0n;
2n;
0x2n;
0o2n;
0b10n;
-0xbf2ed51ff75d380fd3be813ec6185780n;
1 change: 1 addition & 0 deletions test/compare-acorn-es2020/bigint.expected.min.js
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
0n;2n;0x2n;0o2n;0b10n;-0xbf2ed51ff75d380fd3be813ec6185780n
6 changes: 6 additions & 0 deletions test/compare-acorn-es2020/bigint.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
0n;
2n;
0x2n;
0o2n;
0b10n;
-0xbf2ed51ff75d380fd3be813ec6185780n;
95 changes: 95 additions & 0 deletions test/compare-acorn-es2021.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,95 @@
/*
Copyright (C) 2012-2013 Yusuke Suzuki <[email protected]>
Redistribution and use in source and binary forms, with or without
modification, are permitted provided that the following conditions are met:
* Redistributions of source code must retain the above copyright
notice, this list of conditions and the following disclaimer.
* Redistributions in binary form must reproduce the above copyright
notice, this list of conditions and the following disclaimer in the
documentation and/or other materials provided with the distribution.
THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
ARE DISCLAIMED. IN NO EVENT SHALL <COPYRIGHT HOLDER> BE LIABLE FOR ANY
DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
(INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/

'use strict';

var fs = require('fs'),
acorn = require('acorn'),
escodegen = require('./loader'),
chai = require('chai'),
chaiExclude = require('chai-exclude'),
expect = chai.expect;

chai.use(chaiExclude);

function test(code, expected) {
var tree, actual, actualTree, options;

options = {
ranges: false,
locations: false,
ecmaVersion: 12
};

tree = acorn.parse(code, options);

// for UNIX text comment
actual = escodegen.generate(tree);
actualTree = acorn.parse(actual, options);

expect(actual).to.be.equal(expected);
expect(tree).excludingEvery(['start', 'end']).to.deep.equal(actualTree);
}

function testMin(code, expected) {
var tree, actual, actualTree, options;

options = {
ranges: false,
locations: false,
ecmaVersion: 12
};

tree = acorn.parse(code, options);

// for UNIX text comment
actual = escodegen.generate(tree, {
format: escodegen.FORMAT_MINIFY,
raw: false
}).replace(/[\n\r]$/, '') + '\n';
actualTree = acorn.parse(actual, options);

expect(actual).to.be.equal(expected);
expect(tree).excludingEvery(['start', 'end']).to.deep.equal(actualTree);
}

describe('compare acorn es2021 test', function () {
fs.readdirSync(__dirname + '/compare-acorn-es2021').sort().forEach(function(file) {
var code, expected, exp, min;
if (/\.js$/.test(file) && !/expected\.js$/.test(file) && !/expected\.min\.js$/.test(file)) {
it(file, function () {
exp = file.replace(/\.js$/, '.expected.js');
min = file.replace(/\.js$/, '.expected.min.js');
code = fs.readFileSync(__dirname + '/compare-acorn-es2021/' + file, 'utf-8');
expected = fs.readFileSync(__dirname + '/compare-acorn-es2021/' + exp, 'utf-8');
test(code, expected);
if (fs.existsSync(__dirname + '/compare-acorn-es2021/' + min)) {
expected = fs.readFileSync(__dirname + '/compare-acorn-es2021/' + min, 'utf-8');
testMin(code, expected);
}
});
}
});
});
/* vim: set sw=4 ts=4 et tw=80 : */
7 changes: 7 additions & 0 deletions test/compare-acorn-es2021/numeric-separators.expected.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
123_456;
123_456.123_456e+123_456;
0b1010_0001;
0xDEAD_BEAF;
0o755_666;
123_456n;
.012_345;
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
123_456;123_456.123_456e+123_456;0b1010_0001;0xDEAD_BEAF;0o755_666;123_456n;.012_345
7 changes: 7 additions & 0 deletions test/compare-acorn-es2021/numeric-separators.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
123_456;
123_456.123_456e+123_456;
0b1010_0001;
0xDEAD_BEAF;
0o755_666;
123_456n;
.012_345;

0 comments on commit 92c067e

Please sign in to comment.