fix(es_extended/server/functions): improve Core.SavePlayers & Core.SavePlayer#1591
Closed
Kenshiin13 wants to merge 8 commits intoesx-framework:devfrom
Kenshiin13:refactor-player-save
Closed
fix(es_extended/server/functions): improve Core.SavePlayers & Core.SavePlayer#1591Kenshiin13 wants to merge 8 commits intoesx-framework:devfrom Kenshiin13:refactor-player-save
Core.SavePlayers & Core.SavePlayer#1591Kenshiin13 wants to merge 8 commits intoesx-framework:devfrom
Kenshiin13:refactor-player-save
Conversation
Contributor
Author
|
Stale PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Improves the performance of the
Core.SavePlayers&Core.SavePlayerfunctions.Motivation
Larger servers experience regular server thread hitches when ESX saves all of their players. This PR aims to improve that.
Implementation Details
lastPlayTimeplayer metadata on player leave.Core.SavePlayersfunction while keeping the old one enabled by default through a new config option. The new one avoids any native calls entirely by sacraficing the players position, health and armour data. This can be saved on player leave, though it may result in data loss when the client or server crashes.PR Checklist