feat(cli): add cli and remove warning#713
Merged
Merged
Conversation
leoguillaume
force-pushed
the
cli
branch
7 times, most recently
from
62c647b to
c3ed5e3
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| class Providers(BaseModel): | ||
| object: Literal["list"] = "list" | ||
| data: list[Provider] | ||
| from api.infrastructure.fastapi.schemas.providers import Provider, Providers |
Check notice
Code scanning / CodeQL
Unused import Note
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 5 months ago
To fix the problem, remove the unused import of Provider and Providers from api.infrastructure.fastapi.schemas.providers at the bottom of api/schemas/admin/providers.py. This eliminates the unnecessary dependency and resolves both CodeQL alerts.
Concretely, in api/schemas/admin/providers.py, delete the line:
from api.infrastructure.fastapi.schemas.providers import Provider, ProvidersNo other lines, imports, or definitions in the shown snippet need to change, and no new code or imports are required. This change does not alter any existing functionality, because the imported names are not used anywhere in this file.
Suggested changeset
1
api/schemas/admin/providers.py
| @@ -75,6 +75,3 @@ | ||
| raise ValueError("QoS value is required if QoS metric is provided.") | ||
|
|
||
| return self | ||
|
|
||
|
|
||
| from api.infrastructure.fastapi.schemas.providers import Provider, Providers |
Copilot is powered by AI and may make mistakes. Always verify output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.