fix(hotfix): 3 regressions post-EPIC6 — noreply sed, shim idempotence, sync_skills noise (AC-R019 AC-R025 AC-R026)#7
Merged
Conversation
…9 R025 R026) AC-R019 (regression): sed patterns for noreply derivation missed closing quote on JSON key names. Changed '.*"login[[:space:]]*:...' to '.*"login"[[:space:]]*:...' (same for "id"). This caused every PAT to fall back to 'non trouve automatiquement'. Verified against real api.github.com/user response: now extracts login and id correctly. AC-R025: install_shim was short-circuiting on 'file exists', never rewriting when shim content changed (e.g. the exec fix from AC-R022). Now compares first 3 lines of existing shim with expected content; rewrites on mismatch. AC-R026: sync_skills in runtime emitted 'name=<skill>' lines due to bash 3.2 local+assignment quirk. Merged local declarations with assignments (local name="$(basename ...)") to suppress the diagnostic output.
benoitvx
force-pushed
the
feat/hotfix-noreply-shim
branch
from
bb9e18d to
ca8d558
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexte
3 regressions détectées en re-test dogfood après le merge de la PR #6 (feat/onboarding-polish-phaseA).
#1 (BLOQUANT) — AC-R019 (réouvert) : sed noreply jamais matché
Cause : les patterns sed oubliaient le guillemet fermant des clés JSON. GitHub renvoie
"login":"benoitvx"mais le code cherchait"login[[:space:]]*:(sans"fermant) → aucune capture → fallback toujours.Diff :
lib/phases.shlignes 113-114```diff
```
(idem pour "id")
#2 — AC-R025 : install_shim jamais réécrit
Cause :
install_shimfaitif [ -f "$shim_path" ]; then return 0→ après ungit pullqui modifie le contenu du shim (ex. le fix exec dAC-R022), la réinstall ne repose pas le nouveau fichier.Fix : comparer les 3 premières lignes du shim existant avec le contenu attendu ; ne skip que si identique (sinon, réécrire).
#3 — AC-R026 : bruit « name= » dans sync_skills
Cause : bash 3.2 produit un diagnostic
name=<valeur>quandlocal nameprécèdename=$(basename ...)sur deux lignes dans une boucle for.Fix : fusionner
localavec lassignation :local name="$(basename ...)".Tests
Checklist : bash -n OK, backport AC-R019 status dans FEEDBACK.md, log AC-R025 et AC-R026 dans FEEDBACK+BACKLOG.