Fix missing organization_siret in datapass login params payload #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florimondmanca
added
bug
4 tasks
Volubyl
approved these changes
Oct 4, 2022
florimondmanca
force-pushed
the
fm/datapass-contribute
branch
from
05c664f
to
831aff9
Compare
florimondmanca
force-pushed
the
fm/datapass-contribute
branch
from
831aff9
to
a9c4bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #388 (comment)
Le
loginWithDatapassne lisait pas le query paramorganization_siret, dès lors on avait dans le frontuserInfo.account.organizationSiret === null, ce qui provoquait des pb comme celui relevé par Johan.Pour réduire le risque de répétition de ce pb à l'avenir, le front reçoit désormais les infos utilisateur dans un
AuthenticatedUserViewencodé en JSON, qu'il passe directement àtoAccount(), comme pourloginWithPassword.