Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a11y - fix contribuer page #602

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 26 additions & 8 deletions client/src/lib/components/DatasetForm/DatasetForm.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -16,20 +16,20 @@
import { formatHTMLDate } from "$lib/util/format";
import { account } from "src/lib/stores/auth";
import ContactEmailsField from "../ContactEmailsField/ContactEmailsField.svelte";
import GeographicalCoverageField from "./_GeographicalCoverageField.svelte";
import Select from "../Select/Select.svelte";
import InputField from "../InputField/InputField.svelte";
import TextareaField from "../TextareaField/TextareaField.svelte";
import { toSelectOptions } from "src/lib/transformers/form";
import { handleSelectChange } from "src/lib/util/form";
import TagSelector from "../TagSelector/TagSelector.svelte";
import RadioGroupField from "../RadioGroupField/RadioGroupField.svelte";
import LicenseField from "./_LicenseField.svelte";
import LicenseFieldHintText from "./_LicenseFieldHintText.svelte";
import type { Catalog, ExtraFieldValue } from "src/definitions/catalogs";
import ExtraField from "./_ExtraField.svelte";
import Alert from "../Alert/Alert.svelte";
import type { DataFormat } from "src/definitions/dataformat";
import FormatSelector from "../FormatSelector/FormatSelector.svelte";
import SearchableComboBox from "../SearchableComboBox/Basic.svelte";

export let submitLabel = "Publier la fiche de données";
export let loadingLabel = "Publication en cours...";
Expand Down Expand Up @@ -273,11 +273,20 @@
on:input={handleFieldChange}
/>

<GeographicalCoverageField
<SearchableComboBox
name="geographicalCoverage"
label="Couverture géographique"
hintText="Quelle est l'étendue de la zone couverte par ce jeu de données ?"
value={$form.geographicalCoverage}
error={$errors.geographicalCoverage}
suggestions={geographicalCoverages}
on:input={(ev) => updateValidateField("geographicalCoverage", ev.detail)}
options={geographicalCoverages.map((item) => {
return {
label: item,
value: item,
};
})}
on:selectOption={(ev) =>
updateValidateField("geographicalCoverage", ev.detail.value)}
/>
</div>

Expand Down Expand Up @@ -397,11 +406,20 @@
on:input={handleFieldChange}
/>

<LicenseField
<SearchableComboBox
name="license"
required={false}
label="Licence de réutilisation"
hintText={LicenseFieldHintText}
value={$form.license}
error={$errors.license}
suggestions={licenses}
on:input={(ev) => updateValidateField("license", ev.detail)}
options={licenses.map((item) => {
return {
label: item,
value: item,
};
})}
on:selectOption={(ev) => updateValidateField("license", ev.detail.value)}
/>
</div>

Expand Down

This file was deleted.

83 changes: 0 additions & 83 deletions client/src/lib/components/DatasetForm/_LicenseField.spec.ts

This file was deleted.

Loading