Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppression de librairie inutilisée (phoenix_html_sanitizer, voir #1659) #1697

Merged
merged 4 commits into from
Jul 6, 2021

Conversation

thbar
Copy link
Contributor

@thbar thbar commented Jul 6, 2021

Dans #1659, cette librairie a été supprimée.

J'ai lancé durant #1695 la commande mix deps.clean --unlock --unused, et j'ai vu que phoenix_html_sanitizer disparaissait.

J'ai du coup cherché un peu dans le code (pas de trace à première vue de références vers ces composants) et l'historique, et j'ai retrouvé l'explication dans #1659.

Je supprime donc (contexte: #1691/#1683).

@thbar thbar added the dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité label Jul 6, 2021
@thbar thbar requested review from andlio and fchabouis July 6, 2021 07:54
@thbar thbar self-assigned this Jul 6, 2021
Copy link
Contributor

@fchabouis fchabouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thbar thbar merged commit 754c2d4 into master Jul 6, 2021
@thbar thbar deleted the remove-old-deps branch July 6, 2021 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dette technique Entretien & maintenance générale, nécessaire pour que le code reste de bonne qualité
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants