Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use size of events to batch Watch responses #18975

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Speedup resync loop if number of unsynced watchers doesn't go down

3231b06
Select commit
Loading
Failed to load commit list.
Draft

Use size of events to batch Watch responses #18975

Speedup resync loop if number of unsynced watchers doesn't go down
3231b06
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 7, 2025 in 0s

68.76% (-0.07%) compared to b038739

View this Pull Request on Codecov

68.76% (-0.07%) compared to b038739

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.76%. Comparing base (b038739) to head (3231b06).
Report is 371 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/config/config.go 80.23% <100.00%> (ø)
server/etcdserver/api/v3rpc/grpc.go 100.00% <100.00%> (ø)
server/etcdserver/api/v3rpc/watch.go 84.06% <100.00%> (+0.93%) ⬆️
server/etcdserver/server.go 81.86% <100.00%> (-0.34%) ⬇️
server/storage/mvcc/watchable_store.go 94.80% <100.00%> (+1.85%) ⬆️
server/storage/mvcc/watcher_group.go 90.90% <100.00%> (+0.46%) ⬆️

... and 17 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18975      +/-   ##
==========================================
- Coverage   68.82%   68.76%   -0.07%     
==========================================
  Files         420      420              
  Lines       35621    35627       +6     
==========================================
- Hits        24517    24498      -19     
- Misses       9683     9700      +17     
- Partials     1421     1429       +8     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b038739...3231b06. Read the comment docs.