-
Notifications
You must be signed in to change notification settings - Fork 9.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable thelper linter #19271
base: main
Are you sure you want to change the base?
chore: enable thelper linter #19271
Conversation
693c68d
to
168f7db
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files
... and 24 files with indirect coverage changes @@ Coverage Diff @@
## main #19271 +/- ##
==========================================
- Coverage 68.97% 68.93% -0.05%
==========================================
Files 420 420
Lines 35764 35764
==========================================
- Hits 24670 24654 -16
- Misses 9669 9687 +18
+ Partials 1425 1423 -2 Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase this PR, thx
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
168f7db
to
9f5e57e
Compare
9f5e57e
to
2e5f634
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
2e5f634
to
1adb9d7
Compare
/test pull-etcd-integration-1-cpu-amd64 |
Description
enables and fixes thelper linter issues.
Notice that only naming rules are activated here.