Increase the timeout value for e2e downgrade tests #19366
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: henrybear327 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Since the e2e downgrade tests exhibits timeout on the CI more frequently than expected, this PR attempts to increase timeout and see if it will alleviate the situation. Signed-off-by: Chun-Hung Tseng <[email protected]>
henrybear327
force-pushed
the
e2e/increase_downgrade_e2e_test_timeout
branch
from
c273909 to
9cc6361
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #19366 +/- ##
==========================================
- Coverage 68.98% 68.91% -0.08%
==========================================
Files 420 420
Lines 35739 35739
==========================================
- Hits 24656 24628 -28
- Misses 9660 9682 +22
- Partials 1423 1429 +6 Continue to review full report in Codecov by Sentry.
|
| @@ -56,7 +56,7 @@ func DowngradeCancel(t *testing.T, epc *EtcdProcessCluster) { | |||
| c := epc.Etcdctl() | |||
|
|
|||
| var err error | |||
| testutils.ExecuteWithTimeout(t, 1*time.Minute, func() { | |||
| testutils.ExecuteWithTimeout(t, 2*time.Minute, func() { | |||
There was a problem hiding this comment.
Can you elaborate why it takes so long to cancel the downgrade? @henrybear327 @siyuanfoundation
There was a problem hiding this comment.
I haven't had a solid conclusion so far. I will have to investigate deeper to be able to answer
- How often are we getting the time out if we use 1 min
- What are the usual errors that precedes the timeout
There was a problem hiding this comment.
@siyuanfoundation @henrybear327 can you take this as a high priority? I see multiple times of timeout of the downgrade e2e cases.
60s should be already long enough. We need a clearer understanding why it takes so long.
also cc @fuweid
There was a problem hiding this comment.
I am checking this flaky case in my local. I think it maybe related to case. So, I think increasing timeout isn't working
There was a problem hiding this comment.
I will keep looking into this tomorrow morning as my first task.
| @@ -143,7 +143,7 @@ func ValidateMemberVersions(t *testing.T, epc *EtcdProcessCluster, expect []*ver | |||
| } | |||
|
|
|||
| func ValidateVersion(t *testing.T, cfg *EtcdProcessClusterConfig, member EtcdProcess, expect version.Versions) { | |||
| testutils.ExecuteWithTimeout(t, 1*time.Minute, func() { | |||
| testutils.ExecuteWithTimeout(t, 2*time.Minute, func() { | |||
There was a problem hiding this comment.
same question why it takes so long?
There was a problem hiding this comment.
ditto (#19366 (comment))
Since the e2e downgrade tests exhibits timeout on the CI more frequently than expected, this PR attempts to increase timeout and see if it will alleviate the situation.
See one of the timeout being flagged here
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.