Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproduce TestDowngradeCancellationAfterDowngrading2InClusterOf3 failure consistently #19396

Closed
wants to merge 2 commits into from

Conversation

henrybear327
Copy link
Contributor

Implemented findings from Fu Wei. See #19391 (comment)

Execute locally by using the following command:
clear; PASSES="release e2e" PKG=./tests/e2e TESTCASE="TestDowngradeCancellationAfterDowngrading2InClusterOf3" TIMEOUT=20m ./scripts/test.sh -v -failfast

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

…ure consistently

Implemented findings from Fu Wei. See etcd-io#19391 (comment)

Execute locally by using the following command:
clear; PASSES="release e2e" PKG=./tests/e2e TESTCASE="TestDowngradeCancellationAfterDowngrading2InClusterOf3" TIMEOUT=20m ./scripts/test.sh -v -failfast

Signed-off-by: Chun-Hung Tseng <[email protected]>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: henrybear327
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.85%. Comparing base (fefce54) to head (0951f70).
Report is 3 commits behind head on main.

Additional details and impacted files
Files with missing lines Coverage Δ
server/etcdserver/version/monitor.go 96.85% <100.00%> (+0.15%) ⬆️

... and 22 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19396      +/-   ##
==========================================
- Coverage   68.94%   68.85%   -0.10%     
==========================================
  Files         420      420              
  Lines       35759    35770      +11     
==========================================
- Hits        24654    24629      -25     
- Misses       9684     9713      +29     
- Partials     1421     1428       +7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fefce54...0951f70. Read the comment docs.

Signed-off-by: Chun-Hung Tseng <[email protected]>
@k8s-ci-robot
Copy link

@henrybear327: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-e2e-arm64 0951f70 link true /test pull-etcd-e2e-arm64
pull-etcd-e2e-amd64 0951f70 link true /test pull-etcd-e2e-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants