Skip to content

Conversation

henrybear327
Copy link
Contributor

Copy link

codecov bot commented Sep 13, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.05%. Comparing base (9daedd3) to head (4647392).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 19 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #20661      +/-   ##
==========================================
- Coverage   69.15%   69.05%   -0.10%     
==========================================
  Files         420      420              
  Lines       34794    34794              
==========================================
- Hits        24061    24028      -33     
- Misses       9328     9365      +37     
+ Partials     1405     1401       -4     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9daedd3...4647392. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius
Copy link
Member

Is there any other way we could make it work on MacOS without directly targetting it? I don't like to set a precedence that we should accept workarounds for weird behavior of any platform.

@henrybear327 henrybear327 force-pushed the improve-robustness-test-TestDataReports-mac-user-experience branch from eebfd2d to 9cdbfa3 Compare September 14, 2025 08:15
@henrybear327 henrybear327 force-pushed the improve-robustness-test-TestDataReports-mac-user-experience branch from 9cdbfa3 to 4647392 Compare September 14, 2025 08:16
@henrybear327
Copy link
Contributor Author

Is there any other way we could make it work on MacOS without directly targetting it? I don't like to set a precedence that we should accept workarounds for weird behavior of any platform.

Good call :)

I looked further down and realized that we need a directory per test, thus simplifying it further.

@henrybear327
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: henrybear327, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@serathius serathius merged commit 0d60667 into etcd-io:main Sep 14, 2025
32 checks passed
@henrybear327 henrybear327 changed the title Ignore .DS_Store when replaying robustness tests to improve user experience on MacOS Improve test-robustness-reports target to skip non-directory during test Sep 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants