Tasks edit: Simplified task selection

etesync · Jul 16, 2023 · ee51609 · ee51609
1 parent f245798
commit ee51609
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 22 deletions.
diff --git a/src/Tasks/TaskEdit.tsx b/src/Tasks/TaskEdit.tsx
@@ -80,7 +80,7 @@ export default class TaskEdit extends React.PureComponent<PropsType> {
   constructor(props: PropsType) {
     super(props);
     this.state = {
-      parentEntry: "",
+      parentEntry: props.item?.relatedTo ?? "",
       uid: "",
       title: "",
       status: TaskStatusType.NeedsAction,
@@ -552,8 +552,8 @@ export default class TaskEdit extends React.PureComponent<PropsType> {
           entries={this.filterChildren()}
           orig={this.state.parentEntry}
           open={this.state.showSelectorDialog}
-          onConfirm={(entry) => console.log(entry)}
-          onCancel={() => this.setState({ openSelector: false })}
+          onConfirm={(entry) => this.setState({ showSelectorDialog: false, parentEntry: entry })}
+          onCancel={() => this.setState({ showSelectorDialog: false })}
         />
       </React.Fragment>
     );

diff --git a/src/Tasks/TaskSelector.tsx b/src/Tasks/TaskSelector.tsx
@@ -1,4 +1,3 @@
-import { useState } from "react";
 import { TaskType } from "../pim-types";
 import { Button, Dialog, DialogActions, DialogContent, DialogTitle, List } from "@material-ui/core";
 import React from "react";
@@ -13,22 +12,14 @@ interface PropsType {
 }
 
 export default function TaskSelector(props: PropsType) {
-  const [itemId, setItemId] = useState<string | null>(props.orig);
-
-  const select = () => {
-    if (itemId) {
-      props.onConfirm(itemId);
-    }
-  };
 
   const itemList = props.entries.filter((e) => !e.relatedTo)
     .map((e) => 
       <TaskSelectorListItem
         key={e.uid}
         entries={props.entries}
         thisEntry={e}
-        onClick={setItemId}
-        selected={itemId}
+        onClick={props.onConfirm}
       />
     );
 
@@ -43,15 +34,9 @@ export default function TaskSelector(props: PropsType) {
         </List>
       </DialogContent>
       <DialogActions>
-        <Button color="primary" onClick={props.onCancel}>
-          Cancel
-        </Button>
         <Button color="primary" onClick={() => props.onConfirm(null)}>
           Clear
         </Button>
-        <Button color="primary" onClick={select}>
-          Select
-        </Button>
       </DialogActions>
     </Dialog>
   );

diff --git a/src/Tasks/TaskSelectorListItem.tsx b/src/Tasks/TaskSelectorListItem.tsx
@@ -5,7 +5,6 @@ import React from "react";
 interface PropsType {
   entries: TaskType[];
   onClick: (uid: string) => void;
-  selected: string | null;
   thisEntry: TaskType;
 }
 
@@ -15,15 +14,13 @@ export default function TaskSelectorListItem(props: PropsType) {
   return (
     <ListItem
       primaryText={props.thisEntry.title}
-      selected={props.selected === props.thisEntry.uid}
       key={props.thisEntry.uid}
       onClick={() => props.onClick(props.thisEntry.uid)}
       nestedItems={tasks.map((e) => 
         <TaskSelectorListItem
           key={e.uid}
           entries={props.entries}
           onClick={props.onClick}
-          selected={props.selected}
           thisEntry={e}
         />
       )}