Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix: eigensolvers miniapps check #1283

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

albestro
Copy link
Collaborator

Close #1260

@albestro albestro added the Type:Bug Something isn't working label Feb 13, 2025
@albestro albestro added this to the v0.8.0 milestone Feb 13, 2025
@albestro albestro self-assigned this Feb 13, 2025
@albestro
Copy link
Collaborator Author

cscs-ci run

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.07%. Comparing base (47a58ea) to head (54399e7).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1283   +/-   ##
=======================================
  Coverage   95.07%   95.07%           
=======================================
  Files         141      141           
  Lines        8655     8655           
  Branches     1110     1110           
=======================================
  Hits         8229     8229           
  Misses        239      239           
  Partials      187      187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me, but I don't understand the change properly so it's @rasolca who has to approve this...

Copy link
Collaborator

@rasolca rasolca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As by my suggestion in slack...

@rasolca rasolca merged commit c966a24 into master Feb 18, 2025
4 of 5 checks passed
@rasolca rasolca deleted the alby/fix-miniapp-evp-partial-check branch February 18, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Failed check for miniapp_eigensolver with partial backtransformation
4 participants