Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump AMDGPU #74

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Bump AMDGPU #74

merged 3 commits into from
Dec 13, 2023

Conversation

luraess
Copy link
Collaborator

@luraess luraess commented Nov 3, 2023

Include compat for latest releases
Closes #75

@luraess luraess requested a review from omlins November 3, 2023 21:43
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6bac825) 3.50% compared to head (9d9a806) 3.49%.
Report is 4 commits behind head on master.

Files Patch % Lines
src/init_global_grid.jl 0.00% 4 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #74      +/-   ##
=========================================
- Coverage    3.50%   3.49%   -0.01%     
=========================================
  Files           8       8              
  Lines         657     658       +1     
=========================================
  Hits           23      23              
- Misses        634     635       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Project.toml Outdated Show resolved Hide resolved
@luraess luraess closed this Dec 11, 2023
@luraess luraess deleted the lr/bump-amdgpu branch December 11, 2023 10:44
@luraess luraess restored the lr/bump-amdgpu branch December 11, 2023 10:45
@luraess luraess reopened this Dec 11, 2023
@luraess
Copy link
Collaborator Author

luraess commented Dec 11, 2023

This is now tested on Julia 1.9.4 and up to AMDGPU 0.8.2 on LUMI and works both with and without ROCm-aware MPI @omlins

@luraess
Copy link
Collaborator Author

luraess commented Dec 13, 2023

Can we patch release the AMDGPU compat bump @omlins ?

@omlins omlins merged commit be09431 into master Dec 13, 2023
2 of 4 checks passed
@omlins omlins deleted the lr/bump-amdgpu branch December 13, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump AMDGPU version to make IGG run on AMD with non-ROCm APU
3 participants