Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify type definitions for overloaded function #66

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Simplify type definitions for overloaded function #66

wants to merge 2 commits into from

Conversation

jdforsythe
Copy link
Contributor

This just makes the type definitions simpler for the overloaded phin() function

@jdforsythe
Copy link
Contributor Author

jdforsythe commented Mar 2, 2021 •
edited
Loading

@ethanent sorry about the flurry of PRs. I will update this (if you want to merge it) after this other PR to fix the conflicts

#67

Edit: updated with string parsing overload

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jdforsythe @ethan7g