Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.5.0 #20

Merged
merged 86 commits into from
Nov 10, 2023
Merged

v0.5.0 #20

merged 86 commits into from
Nov 10, 2023

Conversation

ethanbass
Copy link
Owner

chromConverter 0.5.0

New features

  • Added support for parallel processing through pbapply package. (Note: The pbapply package must be manually installed to enable parallel processing).
  • Added internal parser for 'Agilent Chemstation' version 31 files (through read_chemstation_uv function).
  • Added support for 'Agilent OpenLab' version 131 files through internal parser.
  • Added preliminary support for reading 'Agilent' (.dx) files (through read_agilentdx function).
  • Added support for reading 'Chemstation' REPORT files.
  • Added parser for Shimadzu .lcd files through the read_shimadzu_lcd function. Only the PDA stream (not MS) is currently supported.
  • Added read_peaklist function for reading peak lists. Currently 'Agilent Chemstation' and 'Shimadzu ASCII' formats are supported.
  • Added verbose argument to control console output for external parsers ('OpenChrom' and 'ThermoRawFileParser').

Other Improvements

  • Improved automatic filetype detection by read_chroms.
  • Refactored read_thermoraw function to simplify paths.
  • The thermoraw and openchrom parsers now use a proper temp directory if an export directory is not specified through the path_out argument.
  • Re-factored reshape_chroms, speeding up conversion from wide to long format.
  • Added additional tests, attaining 82% test coverage.
  • Changed default openchrom export format to mzml.
  • Minor changes to some metadata fields to better standardize results across different file formats and parsers.

Bug fixes

  • Corrected 'Shimadzu' DAD parser so it reads wavelengths from the file instead of inferring them.
  • Fixed bug causing failure of 'Shimadzu' ascii parser (when what == "peak_table" and read_metadata == TRUE).
  • Fixed bug causing 'MDF' files to export as data.frames when format_out == "matrix".
  • Fixed misleading data_format attributes in 'Waters ARW' and 'Chromeleon' parsers.

implemented more general solution that doesn't require existence of metadata stream to pre-determine the number of rows in the chromatogram
fixed data_format attribute bug in chromeleon and shimadzu parsers
- feat: added `metadata_format` argument in `read_waters_arw`, `read_shimadzu`, `read_chromeleon`, `read_cdf`
- fixed bug in chromeleon parser (missing decimal_separator argument)
- added missing whitespace,
- fixed long format bug in read_shimadzu (missing data_format argument)
- removed zombie code
- simplified parsing of paths
- function uses real temp directory now
feat: added `metadata_format` argument to aston and entab parsers

- added whitespace
- fixed long format bug (missing `data_format` argument)
- infer intercept if it can't be read from file
- copy dx before unzipping to prevent file erasure
- added path_out argument to read_agilent_dx
- added better support for automatic filetype detection
- updates to match new behavior of `read_thermoraw`
ethanbass and others added 29 commits September 9, 2023 10:33
- refactored code, splitting off decoding of data into independent functions
- added support for openlab_131
- added rename_list function
moved transfer_metadata function into attach_metadata sourcefile
- use attach_metadata function internally
- move offsets to get_agilent_offsets function
added UV offsets to get_agilent_offsets

Update read_chemstation_ch.Rd
- added metadata_format option
- allow reshaping of 1D chromatograms
- standardized treatment of metadata to improve consistency of results with internal chemstation parsers
@ethanbass ethanbass merged commit 2873753 into master Nov 10, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant