Remove once_cell dependency.#157
Merged
english5040 merged 3 commits intoethangreen-dev:masterfrom Apr 17, 2025
Merged
Conversation
ethangreen-dev
previously requested changes
Apr 12, 2025
Owner
ethangreen-dev
left a comment
ethangreen-dev
left a comment
There was a problem hiding this comment.
Hey! Throw out the rustfmt commit and I'll go ahead and merge this.
IzawGithub
force-pushed
the
Remove-dep-once-cell
branch
from
046d20e to
12dbea2
Compare
Contributor
Author
|
Hello, I've force pushed to remove the |
Owner
|
Yeah, that looks better, It'll make it a lot easier to merge this without the rustfmt changes. I'll merge this after #187 so I'll likely need you to resolve that merge conflict but after that we'll be good to go. |
english5040
dismissed
ethangreen-dev’s stale review
I resolved the merge conflicts myself
english5040
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
once_celldependency had most of it's functionality merged in Rust 1.70.This PR removes it, replacing it with the
stdversion.