Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix textLinesMutator when dealing with insertions/deletions at the end of pad #5253

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Fix textLinesMutator when dealing with insertions/deletions at the end of pad #5253

wants to merge 6 commits into from
+110 −7

Commits on Jun 3, 2024

  1. easysync tests: add some more smartOpAssembler tests

    @webzwo0i @SamTV12345
    webzwo0i authored and SamTV12345 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    97e9ea3 View commit details
    Browse the repository at this point in the history

  2. textLinesMutator: Fix removal at the end of the lines array 

    ...in case we are in the middle of a line (curCol !== 0) and we remove
everything up to the end of the line.

Before this commit a string 'undefined' could make it into the splice.
    @webzwo0i @SamTV12345
    webzwo0i authored and SamTV12345 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    fe5d438 View commit details
    Browse the repository at this point in the history

  3. textLinesMutator: Fix insertions at the end of lines 

    The new insertions are directly pushed to curSplice now instead of
trying to incorporate an undefined line into the splice, which would
result in an error: TypeError: Cannot read property 'substring' of
undefined
    @webzwo0i @SamTV12345
    webzwo0i authored and SamTV12345 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    01b04a6 View commit details
    Browse the repository at this point in the history

  4. textLinesMutator: Fix insertions with newlines at the end of a line 

    In such cases the remaining part of the old line is directly pushed to
the splice but we need to ensure it is not an empty string.
Before this commit an empty string was pushed to the splice.
    @webzwo0i @SamTV12345
    webzwo0i authored and SamTV12345 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f6235ce View commit details
    Browse the repository at this point in the history

  5. fixup! easysync tests: add some more smartOpAssembler tests

    @rhansen @SamTV12345
    rhansen authored and SamTV12345 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    6d224f5 View commit details
    Browse the repository at this point in the history

  6. fixup! textLinesMutator: Fix insertions with newlines at the end of a… 

    … line
    @rhansen @SamTV12345
    rhansen authored and SamTV12345 committed Jun 3, 2024
    Configuration menu
    Copy the full SHA
    f8b41ba View commit details
    Browse the repository at this point in the history